codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2024-11-27 17:46:05 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Include topic title in share links with third parties

Browse source
This commit is contained in:
Neil Lalonde 2013-03-27 16:01:46 -04:00
parent 35f3cd9325
commit d1945057fd
2 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/assets/javascripts/discourse/controllers/share_controller.js
View file

@ -8,6 +8,8 @@
**/
Discourse.ShareController = Discourse.Controller.extend({
needs: ['topic'],
// When the user clicks the post number, we pop up a share box
shareLink: function(e, url) {
var x;
@ -32,7 +34,7 @@ Discourse.ShareController = Discourse.Controller.extend({
shareLinks: function() {
return Discourse.SiteSettings.share_links.split('|').map(function(i) {
if( Discourse.ShareLink.supportedTargets.indexOf(i) >= 0 ) {
return Discourse.ShareLink.create({target: i, link: this.get('link')});
return Discourse.ShareLink.create({target: i, link: this.get('link'), topicTitle: this.get('controllers.topic.title')});
} else {
return null;
}

20
app/assets/javascripts/discourse/models/share_link.js
View file

@ -10,8 +10,8 @@
Discourse.ShareLink = Discourse.Model.extend({
href: function() {
return Discourse.ShareLink.urlFor(this.get('target'), this.get('link'));
}.property('target', 'link'),
return Discourse.ShareLink.urlFor(this.get('target'), this.get('link'), this.get('topicTitle'));
}.property('target', 'link', 'topicTitle'),
title: function() {
return Em.String.i18n("share." + this.get('target'));
@ -27,27 +27,27 @@ Discourse.ShareLink.reopenClass({
supportedTargets: ['twitter', 'facebook', 'google+'],
urlFor: function(target,link) {
urlFor: function(target,link,title) {
switch(target) {
case 'twitter':
return this.twitterUrl(link);
return this.twitterUrl(link,title);
case 'facebook':
return this.facebookUrl(link);
return this.facebookUrl(link,title);
case 'google+':
return this.googlePlusUrl(link);
}
},
twitterUrl: function(link) {
return ("http://twitter.com/home?status=" + link);
twitterUrl: function(link, title) {
return ("http://twitter.com/intent/tweet?url=" + encodeURIComponent(link) + "&text=" + encodeURIComponent(title) );
},
facebookUrl: function(link) {
return ("http://www.facebook.com/sharer.php?u=" + link);
facebookUrl: function(link, title) {
return ("http://www.facebook.com/sharer.php?u=" + encodeURIComponent(link) + '&t=' + encodeURIComponent(title));
},
googlePlusUrl: function(link) {
return ("https://plus.google.com/share?url=" + link);
return ("https://plus.google.com/share?url=" + encodeURIComponent(link));
},
iconClasses: {