From cd3a2143d234798a96f23eaefb73b3a0a358a1cb Mon Sep 17 00:00:00 2001
From: Wojciech Zawistowski <wojciech.zawistowski@gmail.com>
Date: Thu, 19 Sep 2013 17:26:43 +0200
Subject: [PATCH] remove unnecessary return statement inside
Discourse.Router.map
Ember's Router.map(callback) method doesn't expect any value to be
returned by callback function. Therefore, return statements present
inside Discourse.Router.map are unnecessary (and are silently ignored by
Ember).
---
app/views/common/_discourse_javascript.html.erb | 2 +-
test/javascripts/test_helper.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/views/common/_discourse_javascript.html.erb b/app/views/common/_discourse_javascript.html.erb
index d9f58b76d..bf1eea711 100644
--- a/app/views/common/_discourse_javascript.html.erb
+++ b/app/views/common/_discourse_javascript.html.erb
@@ -22,7 +22,7 @@
Discourse.BaseUri = '<%= Discourse::base_uri "/" %>';
Discourse.Environment = '<%= Rails.env %>';
Discourse.Router.map(function() {
- return Discourse.routeBuilder.call(this);
+ Discourse.routeBuilder.call(this);
});
Discourse.start()
</script>
diff --git a/test/javascripts/test_helper.js b/test/javascripts/test_helper.js
index 3ce62b993..3093140ca 100644
--- a/test/javascripts/test_helper.js
+++ b/test/javascripts/test_helper.js
@@ -71,7 +71,7 @@ Discourse.injectTestHelpers();
Discourse.bindDOMEvents();
Discourse.Router.map(function() {
- return Discourse.routeBuilder.call(this);
+ Discourse.routeBuilder.call(this);
});