From be93f224a656d814843c9511e8811bcf9cf93718 Mon Sep 17 00:00:00 2001
From: Robin Ward <robin.ward@gmail.com>
Date: Wed, 1 Oct 2014 10:30:26 -0400
Subject: [PATCH] Revert "add user email on account created page"

This reverts commit 164fc1108aa5349b5be1fa189b854dcb9c542f23.
---
 .../javascripts/discourse/controllers/create-account.js.es6  | 3 +--
 app/controllers/users_controller.rb                          | 5 -----
 app/views/users/account_created.html.erb                     | 2 +-
 config/locales/server.en.yml                                 | 2 +-
 config/routes.rb                                             | 2 +-
 5 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/app/assets/javascripts/discourse/controllers/create-account.js.es6 b/app/assets/javascripts/discourse/controllers/create-account.js.es6
index 198c0d04f..7d846513b 100644
--- a/app/assets/javascripts/discourse/controllers/create-account.js.es6
+++ b/app/assets/javascripts/discourse/controllers/create-account.js.es6
@@ -362,10 +362,9 @@ export default DiscourseController.extend(ModalFunctionality, {
         if (result.success) {
           // Trigger the browser's password manager using the hidden static login form:
           var $hidden_login_form = $('#hidden-login-form');
-          var account_created_url = Discourse.getURL('/users/' + self.get('accountUsername') + '/account-created');
           $hidden_login_form.find('input[name=username]').val(attrs.accountName);
           $hidden_login_form.find('input[name=password]').val(attrs.accountPassword);
-          $hidden_login_form.find('input[name=redirect]').val(account_created_url);
+          $hidden_login_form.find('input[name=redirect]').val(Discourse.getURL('/users/account-created'));
           $hidden_login_form.submit();
         } else {
           self.flash(result.message || I18n.t('create_account.failed'), 'error');
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 6489cd2c7..806315ca8 100644
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -338,11 +338,6 @@ class UsersController < ApplicationController
   end
 
   def account_created
-    params.require(:username)
-    @user = User.find_by_username_or_email(params[:username].to_s)
-
-    raise Discourse::NotFound unless @user
-
     expires_now
     render layout: 'no_js'
   end
diff --git a/app/views/users/account_created.html.erb b/app/views/users/account_created.html.erb
index b42204812..ce13d4f14 100644
--- a/app/views/users/account_created.html.erb
+++ b/app/views/users/account_created.html.erb
@@ -1,3 +1,3 @@
 <div id='simple-container'>
-  <span style="font-size: 16px; line-height: 24px;"><%= t('login.activate_email', email: @user.email).html_safe %></span>
+  <span style="font-size: 16px; line-height: 24px;"><%= t 'login.activate_email' %></span>
 </div>
diff --git a/config/locales/server.en.yml b/config/locales/server.en.yml
index bf64f9c9e..62500b33a 100644
--- a/config/locales/server.en.yml
+++ b/config/locales/server.en.yml
@@ -1087,7 +1087,7 @@ en:
     incorrect_username_email_or_password: "Incorrect username, email or password"
     wait_approval: "Thanks for signing up. We will notify you when your account has been approved."
     active: "Your account is activated and ready to use."
-    activate_email: "<p>You're almost done! We sent an activation mail to <b>%{email}</b>. Please follow the instructions in the email to activate your account.</p><p>If it doesn't arrive, check your spam folder, or try to log in again to send another activation mail.</p>"
+    activate_email: "You're almost done! We sent an activation mail to the email address you provided. Please follow the instructions in the email to activate your account."
     not_activated: "You can't log in yet. We sent an activation email to you. Please follow the instructions in the email to activate your account."
     not_allowed_from_ip_address: "You can't login as %{username} from that IP address."
     suspended: "You can't log in until %{date}."
diff --git a/config/routes.rb b/config/routes.rb
index f0ca22f32..8d9c0a6ab 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -207,7 +207,7 @@ Discourse::Application.routes.draw do
 
   post "users/read-faq" => "users#read_faq"
   get "users/search/users" => "users#search_users"
-  get "users/:username/account-created" => "users#account_created", constraints: {username: USERNAME_ROUTE_FORMAT}
+  get "users/account-created/" => "users#account_created"
   get "users/password-reset/:token" => "users#password_reset"
   put "users/password-reset/:token" => "users#password_reset"
   get "users/activate-account/:token" => "users#activate_account"