UX: clean up title for user avatar hover in header

app/assets/javascripts/discourse/controllers/header.js.es6

@@ -18,10 +18,6 @@ const HeaderController = DiscourseController.extend({
     return Discourse.User.current() && !this.get('topic.isPrivateMessage');
   }.property('topic.isPrivateMessage'),
 
-  userDisplayName: function() {
-    return (Discourse.SiteSettings.enable_names && this.get('currentUser.name')) ? this.get('currentUser.name') : this.get('currentUser.username');
-  }.property('currentUser.name', 'currentUser.username'),
-
   _resetCachedNotifications: function() {
     // a bit hacky, but if we have no focus, hide notifications first
     const visible = $("#notifications-dropdown").is(":visible");

app/assets/javascripts/discourse/templates/header.hbs

@@ -54,6 +54,7 @@
                data-render="renderSiteMap"
                href
                title='{{i18n 'site_map'}}'
+               aria-label='{{i18n 'site_map'}}'
                id="site-map">
                {{fa-icon "bars" label="site_map"}}
             </a>
@@ -68,7 +69,8 @@
                data-dropdown="user-dropdown"
                data-render="renderUserDropdown"
                href="#"
-               title='{{i18n 'user.avatar.title' name=userDisplayName}}'
+               title='{{i18n 'user.avatar.header_title'}}'
+               aria-label='{{i18n 'user.avatar.header_title'}}'
                id="current-user">
                  {{bound-avatar currentUser "medium"}}
             </a>

config/locales/client.en.yml

@@ -587,7 +587,8 @@ en:
       registration_ip_address:
         title: "Registration IP Address"
       avatar:
-        title: "{{name}} profile"
+        title: "Profile Picture"
+        header_title: "profile, messages, bookmarks and preferences"
       title:
         title: "Title"