mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-27 17:46:05 -05:00
Strip spaces from group names upon creation
This commit is contained in:
parent
38b8e9b1b4
commit
b223cdb493
2 changed files with 25 additions and 11 deletions
|
@ -31,7 +31,7 @@ class Admin::GroupsController < Admin::AdminController
|
|||
|
||||
def create
|
||||
group = Group.new
|
||||
group.name = params[:group][:name]
|
||||
group.name = params[:group][:name].strip
|
||||
group.usernames = params[:group][:usernames] if params[:group][:usernames]
|
||||
group.save!
|
||||
render_serialized(group, BasicGroupSerializer)
|
||||
|
|
|
@ -48,9 +48,12 @@ describe Admin::GroupsController do
|
|||
end
|
||||
end
|
||||
|
||||
context '.create' do
|
||||
let(:usernames) { @admin.username }
|
||||
|
||||
it "is able to create a group" do
|
||||
xhr :post, :create, group: {
|
||||
usernames: @admin.username,
|
||||
usernames: usernames,
|
||||
name: "bob"
|
||||
}
|
||||
|
||||
|
@ -59,10 +62,21 @@ describe Admin::GroupsController do
|
|||
groups = Group.where(name: "bob").to_a
|
||||
|
||||
groups.count.should == 1
|
||||
groups[0].usernames.should == @admin.username
|
||||
groups[0].usernames.should == usernames
|
||||
groups[0].name.should == "bob"
|
||||
end
|
||||
|
||||
it "strips spaces from group name" do
|
||||
lambda {
|
||||
xhr :post, :create, group: {
|
||||
usernames: usernames,
|
||||
name: " bob "
|
||||
}
|
||||
}.should_not raise_error(ActiveRecord::RecordInvalid)
|
||||
Group.where(name: "bob").count.should == 1
|
||||
end
|
||||
end
|
||||
|
||||
it "is able to update group members" do
|
||||
user1 = Fabricate(:user)
|
||||
user2 = Fabricate(:user)
|
||||
|
|
Loading…
Reference in a new issue