codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2025-05-04 09:54:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

BUGFIX: don't leak out a transaction if fails

Browse source
This commit is contained in:
Sam 2014-01-31 11:38:18 +11:00
parent f71c8bb533
commit 9fc3a335cc
1 changed files with 14 additions and 8 deletions

22
app/jobs/regular/importer.rb
View file

@ -188,16 +188,22 @@ module Jobs
parameter_markers = fields.map {|x| "?"}.join(',') parameter_markers = fields.map {|x| "?"}.join(',')
sql_stmt = "INSERT INTO #{table_name} (#{fields.join(',')}) VALUES (#{parameter_markers})" sql_stmt = "INSERT INTO #{table_name} (#{fields.join(',')}) VALUES (#{parameter_markers})"
User.exec_sql("BEGIN TRANSACTION") unless Rails.env.test? in_tran = false
i = 0 begin
rows.each do |row| User.exec_sql("BEGIN TRANSACTION") unless Rails.env.test?
if i % batch_size == 0 && i > 0 in_tran = true
log "#{i} rows done" i = 0
rows.each do |row|
if i % batch_size == 0 && i > 0
log "#{i} rows done"
end
User.exec_sql(sql_stmt, *row)
i += 1
end end
User.exec_sql(sql_stmt, *row) User.exec_sql("COMMIT") unless Rails.env.test?
i += 1 rescue
User.exec_sql("ROLLBACK") if in_tran
end end
User.exec_sql("COMMIT") unless Rails.env.test?
true true
else else