From 98404d19c5bd03ede586656a44730991b77b3122 Mon Sep 17 00:00:00 2001
From: "Jason W. May" <jmay@pobox.com>
Date: Fri, 21 Nov 2014 10:03:29 -0800
Subject: [PATCH] check that `changes` param is present
---
app/controllers/admin/groups_controller.rb | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/app/controllers/admin/groups_controller.rb b/app/controllers/admin/groups_controller.rb
index df21a4328..0dd4dc8af 100644
--- a/app/controllers/admin/groups_controller.rb
+++ b/app/controllers/admin/groups_controller.rb
@@ -23,15 +23,16 @@ class Admin::GroupsController < Admin::AdminController
def update_patch(group)
raise Discourse::InvalidAccess.new("automatic groups do not permit membership changes") if group.automatic
- actions = params[:changes]
- Array(actions[:add]).each do |username|
- if user = User.find_by_username(username)
- group.add(user)
+ if actions = params[:changes]
+ Array(actions[:add]).each do |username|
+ if user = User.find_by_username(username)
+ group.add(user)
+ end
end
- end
- Array(actions[:delete]).each do |username|
- if user = User.find_by_username(username)
- group.remove(user)
+ Array(actions[:delete]).each do |username|
+ if user = User.find_by_username(username)
+ group.remove(user)
+ end
end
end