codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2024-11-27 09:36:19 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

PERF: skip optimizing large letter avatar makes image bigger

Browse source
This commit is contained in:
Sam 2015-09-10 11:54:17 +10:00
parent 38cb72b329
commit 90ad943dd3
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/letter_avatar.rb
View file

@ -45,6 +45,9 @@ class LetterAvatar
fullsize = fullsize_path(identity) fullsize = fullsize_path(identity)
generate_fullsize(identity) if !cache || !File.exists?(fullsize) generate_fullsize(identity) if !cache || !File.exists?(fullsize)
# Optimizing here is dubious, it can save up to 2x for large images (eg 359px)
# BUT... we are talking 2400 bytes down to 1200 bytes, both fit in one packet
# The cost of this is huge, its a 40% perf hit
OptimizedImage.resize(fullsize, filename, size, size) OptimizedImage.resize(fullsize, filename, size, size)
filename filename
@ -81,8 +84,7 @@ class LetterAvatar
`convert #{instructions.join(" ")}` `convert #{instructions.join(" ")}`
ImageOptim.new.optimize_image!(filename) rescue nil ## do not optimize image, it will end up larger than original
filename filename
end end