codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2025-02-25 16:04:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "FIX: properly filter badges when they're on a whisper"

Browse source 
This reverts commit 6b07575632.
This commit is contained in:
Sam 2015-09-25 10:20:47 +10:00
parent 2422289c8b
commit 8da8999aa1
1 changed files with 6 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
app/controllers/user_badges_controller.rb
View file

@ -3,9 +3,8 @@ class UserBadgesController < ApplicationController
params.permit [:granted_before, :offset] params.permit [:granted_before, :offset]
badge = fetch_badge_from_params badge = fetch_badge_from_params
user_badges = filter_user_badges(badge.user_badges) user_badges = badge.user_badges.order('granted_at DESC, id DESC').limit(96)
user_badges = user_badges.includes(:user, :granted_by, badge: :badge_type, post: :topic) user_badges = user_badges.includes(:user, :granted_by, badge: :badge_type, post: :topic)
user_badges = user_badges.order(granted_at: :desc, id: :desc).limit(96)
if offset = params[:offset] if offset = params[:offset]
user_badges = user_badges.offset(offset.to_i) user_badges = user_badges.offset(offset.to_i)
@ -18,16 +17,17 @@ class UserBadgesController < ApplicationController
params.permit [:grouped] params.permit [:grouped]
user = fetch_user_from_params user = fetch_user_from_params
user_badges = filter_user_badges(user.user_badges) user_badges = user.user_badges
user_badges = user_badges.includes(badge: [:badge_grouping, :badge_type])
.includes(post: :topic)
.includes(:granted_by)
if params[:grouped] if params[:grouped]
user_badges = user_badges.group(:badge_id) user_badges = user_badges.group(:badge_id)
.select(UserBadge.attribute_names.map {|x| "MAX(#{x}) as #{x}" }, 'COUNT(*) as count') .select(UserBadge.attribute_names.map {|x| "MAX(#{x}) as #{x}" }, 'COUNT(*) as count')
end end
user_badges = user_badges.includes(badge: [:badge_grouping, :badge_type])
.includes(post: :topic)
.includes(:granted_by)
render_serialized(user_badges, DetailedUserBadgeSerializer, root: "user_badges") render_serialized(user_badges, DetailedUserBadgeSerializer, root: "user_badges")
end end
@ -94,15 +94,4 @@ class UserBadgesController < ApplicationController
master_api_call = current_user.nil? && is_api? master_api_call = current_user.nil? && is_api?
master_api_call or guardian.can_grant_badges?(user) master_api_call or guardian.can_grant_badges?(user)
end end
def filter_user_badges(user_badges)
if SiteSetting.enable_whispers?
unless current_user.try(:staff?)
user_badges = user_badges.joins("LEFT JOIN posts ON posts.id = user_badges.post_id")
.where("posts.post_type <> #{Post.types[:whisper]}")
end
end
user_badges
end
end end