From 7c2927f8ab0a51bdf68b3b7d7cedf2d921d94d22 Mon Sep 17 00:00:00 2001
From: Dan Dascalescu <ddascalescu+github@gmail.com>
Date: Tue, 22 Sep 2015 22:31:42 -0700
Subject: [PATCH] Fix username conversion. Add comments.
---
script/import_scripts/mybb.rb | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/script/import_scripts/mybb.rb b/script/import_scripts/mybb.rb
index e3790e69b..19c5bd1d4 100644
--- a/script/import_scripts/mybb.rb
+++ b/script/import_scripts/mybb.rb
@@ -153,15 +153,18 @@ class ImportScripts::MyBB < ImportScripts::Base
puts '', "banned users are not implemented"
end
+ # Discourse usernames don't allow spaces
def convert_username(username, post_id)
count = 0
- username.gsub!(' ') { |a| count += 1; ' ' }
+ username.gsub!(' ') { |a| count += 1; '_' }
+ # Warn on MyBB bug that places post text in the quote line - http://community.mybb.com/thread-180526.html
if count > 5
puts "Warning: probably incorrect quote in post #{post_id}"
end
return username
end
+ # Take an original post id and return the migrated topic id and post number for it
def post_id_to_post_num_and_topic(quoted_post_id, post_id)
quoted_post_id_from_imported = post_id_from_imported_post_id(quoted_post_id.to_i)
if quoted_post_id_from_imported