From 722e1fc4d059ec6732c512493d2356ecd7e81bea Mon Sep 17 00:00:00 2001
From: Sam <sam.saffron@gmail.com>
Date: Mon, 28 Sep 2015 16:40:02 +1000
Subject: [PATCH] PERF: avoid needless queries on non private messages

---
 app/serializers/topic_view_serializer.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/serializers/topic_view_serializer.rb b/app/serializers/topic_view_serializer.rb
index 821ae8329..a109ff34a 100644
--- a/app/serializers/topic_view_serializer.rb
+++ b/app/serializers/topic_view_serializer.rb
@@ -65,13 +65,13 @@ class TopicViewSerializer < ApplicationSerializer
       last_poster: BasicUserSerializer.new(object.topic.last_poster, scope: scope, root: false)
     }
 
-    if object.topic.allowed_users.present?
+    if object.topic.private_message?
       result[:allowed_users] = object.topic.allowed_users.map do |user|
         BasicUserSerializer.new(user, scope: scope, root: false)
       end
     end
 
-    if object.topic.allowed_groups.present?
+    if object.topic.private_message?
       result[:allowed_groups] = object.topic.allowed_groups.map do |ag|
         BasicGroupSerializer.new(ag, scope: scope, root: false)
       end