codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2024-11-23 15:48:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

SECURITY: do not follow redirect by default when downloading hotlinked images

Browse source
This commit is contained in:
Régis Hanol 2014-07-27 17:21:47 +02:00
parent 621b86dbb3
commit 488d4eebbe
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/file_helper.rb
View file

@ -6,7 +6,7 @@ class FileHelper
filename =~ images_regexp
end
def self.download(url, max_file_size, tmp_file_name)
def self.download(url, max_file_size, tmp_file_name, follow_redirect=false)
raise Discourse::InvalidParameters.new(:url) unless url =~ /^https?:\/\//
uri = URI.parse(url)
@ -14,7 +14,7 @@ class FileHelper
tmp = Tempfile.new([tmp_file_name, extension])
File.open(tmp.path, "wb") do |f|
downloaded = uri.open("rb", read_timeout: 5)
downloaded = uri.open("rb", read_timeout: 5, redirect: follow_redirect)
while f.size <= max_file_size && data = downloaded.read(max_file_size)
f.write(data)
end