Revert "FEATURE: make discourse remap optionally do regex_replace"

script/discourse

@@ -6,31 +6,27 @@ class DiscourseCLI < Thor
   class_option :verbose, default: false, aliases: :v
 
   desc "remap", "Remap a string sequence accross all tables"
-  option :global, :type => :boolean
-  option :regex, :type => :boolean
-  def remap(from, to)
+  def remap(from, to, global=nil)
     load_rails
 
-    if options[:regex]
-      puts "Rewriting all occurences of #{from} to #{to} using regexp_replace"
-    else
+    global = global == "--global"
+
     puts "Rewriting all occurences of #{from} to #{to}"
-    end
     puts "THIS TASK WILL REWRITE DATA, ARE YOU SURE (type YES)"
-    puts "WILL RUN ON ALL #{RailsMultisite::ConnectionManagement.all_dbs.length} DBS" if options[:global]
+    puts "WILL RUN ON ALL #{RailsMultisite::ConnectionManagement.all_dbs.length} DBS" if global
     text = STDIN.gets
     if text.strip != "YES"
       puts "aborting."
       exit
     end
 
-    if options[:global]
+    if global
       RailsMultisite::ConnectionManagement.each_connection do |db|
         puts "","Remapping tables on #{db}...",""
-        do_remap(from, to, options[:regex])
+        do_remap(from, to)
       end
     else
-      do_remap(from, to, options[:regex])
+      do_remap(from, to)
     end
   end
 
@@ -200,7 +196,7 @@ class DiscourseCLI < Thor
     require File.expand_path(File.dirname(__FILE__) + "/../lib/import_export/import_export")
   end
 
-  def do_remap(from, to, regex=false)
+  def do_remap(from, to)
     sql = "SELECT table_name, column_name
 FROM information_schema.columns
 WHERE table_schema='public' and (data_type like 'char%' or data_type like 'text%') and is_updatable = 'YES'"
@@ -214,17 +210,10 @@ WHERE table_schema='public' and (data_type like 'char%' or data_type like 'text%
       column_name = result["column_name"]
       puts "Remapping #{table_name} #{column_name}"
       begin
-        result = if regex
-          cnn.async_exec("UPDATE #{table_name}
-            SET #{column_name} = regexp_replace(#{column_name}, $1, $2, 'g')
-            WHERE NOT #{column_name} IS NULL
-              AND #{column_name} <> regexp_replace(#{column_name}, $1, $2, 'g')", [from, to])
-        else
-          cnn.async_exec("UPDATE #{table_name}
+        result = cnn.async_exec("UPDATE #{table_name}
                         SET #{column_name} = replace(#{column_name}, $1, $2)
                         WHERE NOT #{column_name} IS NULL
                           AND #{column_name} <> replace(#{column_name}, $1, $2)", [from, to])
-        end
         puts "#{result.cmd_tuples} rows affected!"
       rescue => ex
         puts "Error: #{ex}"