From 30e4b17de8d6ccb3c9dd328476c1a043d0971199 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 10 Jun 2016 13:07:35 +1000 Subject: [PATCH] UX: strip outgoing links from bottom of post. Only show incoming --- .../discourse/widgets/post-links.js.es6 | 33 +++++++++++-------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/app/assets/javascripts/discourse/widgets/post-links.js.es6 b/app/assets/javascripts/discourse/widgets/post-links.js.es6 index 50624d0e0..ca17d358c 100644 --- a/app/assets/javascripts/discourse/widgets/post-links.js.es6 +++ b/app/assets/javascripts/discourse/widgets/post-links.js.es6 @@ -20,37 +20,42 @@ export default createWidget('post-links', { return h('li', h('a.track-link', { - className: link.reflection ? 'inbound' : 'outbound', + className: 'inbound', attributes: { href: link.url } - }, [iconNode(link.reflection ? 'arrow-left' : 'arrow-right'), linkBody]) + }, [iconNode('arrow-left'), linkBody]) ); }, html(attrs, state) { - const links = this.attrs.links || []; - const dedupedLinks = _.uniq(links, true, l => l.title); - const incomingLinks = dedupedLinks.filter(l => l.reflection); + if (!this.attrs.links || this.attrs.links.length == 0) { + // shortcut all work + return; + } - // if all links are outgoing, don't show any - if (incomingLinks.length === 0) { return; } + // only show incoming + const links = _(this.attrs.links) + .filter(l => l.reflection) + .uniq(true, l => l.title) + .value(); + + if (links.length === 0) { return; } const result = []; // show all links - if (dedupedLinks.length <= 5 || !state.collapsed) { - _.each(dedupedLinks, l => result.push(this.linkHtml(l))); + if (links.length <= 5 || !state.collapsed) { + _.each(links, l => result.push(this.linkHtml(l))); } else { - // show up to 5 *incoming* links when collapsed - const max = Math.min(5, incomingLinks.length); + const max = Math.min(5, links.length); for (let i = 0; i < max; i++) { - result.push(this.linkHtml(incomingLinks[i])); + result.push(this.linkHtml(links[i])); } // 'show more' link - if (dedupedLinks.length > max) { + if (links.length > max) { result.push(h('li', this.attach('link', { labelCount: 'post_links.title', title: 'post_links.about', - count: dedupedLinks.length - max, + count: links.length - max, action: 'expandLinks', className: 'expand-links' })));