From 206ef3dc084edf0c0bbb94e2836bcd4e92f13b07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9gis=20Hanol?= <regis@hanol.fr>
Date: Mon, 16 Dec 2013 18:11:46 +0100
Subject: [PATCH] add discourse_diff tests
---
app/serializers/post_revision_serializer.rb | 2 +-
lib/discourse_diff.rb | 10 +-
spec/components/discourse_diff_spec.rb | 124 ++++++++++++++++++++
3 files changed, 130 insertions(+), 6 deletions(-)
create mode 100644 spec/components/discourse_diff_spec.rb
diff --git a/app/serializers/post_revision_serializer.rb b/app/serializers/post_revision_serializer.rb
index 1f176fddd..fc3ccef97 100644
--- a/app/serializers/post_revision_serializer.rb
+++ b/app/serializers/post_revision_serializer.rb
@@ -47,7 +47,7 @@ class PostRevisionSerializer < ApplicationSerializer
end
def side_by_side_markdown
- DiscourseDiff.new(previous_raw, raw).side_by_side_text
+ DiscourseDiff.new(previous_raw, raw).side_by_side_markdown
end
private
diff --git a/lib/discourse_diff.rb b/lib/discourse_diff.rb
index cf0d35eda..ea5152ac2 100644
--- a/lib/discourse_diff.rb
+++ b/lib/discourse_diff.rb
@@ -84,7 +84,7 @@ class DiscourseDiff
"<div class=\"span8\">#{left.join}</div><div class=\"span8 offset1\">#{right.join}</div>"
end
- def side_by_side_text
+ def side_by_side_markdown
i = 0
table = ["<table class=\"markdown\">"]
while i < @line_by_line_diff.length
@@ -105,12 +105,12 @@ class DiscourseDiff
end
if i + 1 < @line_by_line_diff.length && @line_by_line_diff[i + 1][1] == opposite_op_code
- before_tokens, after_tokens = tokenize_text(@line_by_line_diff[first][0]), tokenize_text(@line_by_line_diff[second][0])
+ before_tokens, after_tokens = tokenize_markdown(@line_by_line_diff[first][0]), tokenize_markdown(@line_by_line_diff[second][0])
if (before_tokens.length - after_tokens.length).abs > MAX_DIFFERENCE
before_tokens, after_tokens = tokenize_line(@line_by_line_diff[first][0]), tokenize_line(@line_by_line_diff[second][0])
end
diff = ONPDiff.new(before_tokens, after_tokens).short_diff
- deleted, inserted = generate_side_by_side_text(diff)
+ deleted, inserted = generate_side_by_side_markdown(diff)
table << "<td class=\"diff-del\">#{deleted.join}</td>"
table << "<td class=\"diff-ins\">#{inserted.join}</td>"
i += 1
@@ -138,7 +138,7 @@ class DiscourseDiff
text.scan(/[^\r\n]+[\r\n]*/)
end
- def tokenize_text(text)
+ def tokenize_markdown(text)
t, tokens = [], []
i = 0
while i < text.length
@@ -214,7 +214,7 @@ class DiscourseDiff
[deleted, inserted]
end
- def generate_side_by_side_text(diff)
+ def generate_side_by_side_markdown(diff)
deleted, inserted = [], []
diff.each do |d|
case d[1]
diff --git a/spec/components/discourse_diff_spec.rb b/spec/components/discourse_diff_spec.rb
new file mode 100644
index 000000000..e96b01e5a
--- /dev/null
+++ b/spec/components/discourse_diff_spec.rb
@@ -0,0 +1,124 @@
+require 'spec_helper'
+require 'discourse_diff'
+
+describe DiscourseDiff do
+
+ describe "inline_html" do
+
+ it "returns an empty div when no content is diffed" do
+ DiscourseDiff.new("", "").inline_html.should == "<div class=\"inline-diff\"></div>"
+ end
+
+ it "returns the diffed content when there is no difference" do
+ before = after = "<p>this is a paragraph</p>"
+ DiscourseDiff.new(before, after).inline_html.should == "<div class=\"inline-diff\"><p>this is a paragraph</p></div>"
+ end
+
+ it "adds <ins> tags around added text" do
+ before = "<p>this is a paragraph</p>"
+ after = "<p>this is a great paragraph</p>"
+ DiscourseDiff.new(before, after).inline_html.should == "<div class=\"inline-diff\"><p>this is a <ins>great </ins>paragraph</p></div>"
+ end
+
+ it "adds <del> tags around removed text" do
+ before = "<p>this is a great paragraph</p>"
+ after = "<p>this is a paragraph</p>"
+ DiscourseDiff.new(before, after).inline_html.should == "<div class=\"inline-diff\"><p>this is a <del>great </del>paragraph</p></div>"
+ end
+
+ it "adds .diff-ins class when a paragraph is added" do
+ before = "<p>this is the first paragraph</p>"
+ after = "<p>this is the first paragraph</p><p>this is the second paragraph</p>"
+ DiscourseDiff.new(before, after).inline_html.should == "<div class=\"inline-diff\"><p>this is the first paragraph</p><p class=\"diff-ins\">this is the second paragraph</p></div>"
+ end
+
+ it "adds .diff-del class when a paragraph is removed" do
+ before = "<p>this is the first paragraph</p><p>this is the second paragraph</p>"
+ after = "<p>this is the second paragraph</p>"
+ DiscourseDiff.new(before, after).inline_html.should == "<div class=\"inline-diff\"><p class=\"diff-del\">this is the first paragraph</p><p>this is the second paragraph</p></div>"
+ end
+
+ end
+
+ describe "side_by_side_html" do
+
+ it "returns two empty divs when no content is diffed" do
+ DiscourseDiff.new("", "").side_by_side_html.should == "<div class=\"span8\"></div><div class=\"span8 offset1\"></div>"
+ end
+
+ it "returns the diffed content on both sides when there is no difference" do
+ before = after = "<p>this is a paragraph</p>"
+ DiscourseDiff.new(before, after).side_by_side_html.should == "<div class=\"span8\"><p>this is a paragraph</p></div><div class=\"span8 offset1\"><p>this is a paragraph</p></div>"
+ end
+
+ it "adds <ins> tags around added text on the right div" do
+ before = "<p>this is a paragraph</p>"
+ after = "<p>this is a great paragraph</p>"
+ DiscourseDiff.new(before, after).side_by_side_html.should == "<div class=\"span8\"><p>this is a paragraph</p></div><div class=\"span8 offset1\"><p>this is a <ins>great </ins>paragraph</p></div>"
+ end
+
+ it "adds <del> tags around removed text on the left div" do
+ before = "<p>this is a great paragraph</p>"
+ after = "<p>this is a paragraph</p>"
+ DiscourseDiff.new(before, after).side_by_side_html.should == "<div class=\"span8\"><p>this is a <del>great </del>paragraph</p></div><div class=\"span8 offset1\"><p>this is a paragraph</p></div>"
+ end
+
+ it "adds .diff-ins class when a paragraph is added" do
+ before = "<p>this is the first paragraph</p>"
+ after = "<p>this is the first paragraph</p><p>this is the second paragraph</p>"
+ DiscourseDiff.new(before, after).side_by_side_html.should == "<div class=\"span8\"><p>this is the first paragraph</p></div><div class=\"span8 offset1\"><p>this is the first paragraph</p><p class=\"diff-ins\">this is the second paragraph</p></div>"
+ end
+
+ it "adds .diff-del class when a paragraph is removed" do
+ before = "<p>this is the first paragraph</p><p>this is the second paragraph</p>"
+ after = "<p>this is the second paragraph</p>"
+ DiscourseDiff.new(before, after).side_by_side_html.should == "<div class=\"span8\"><p class=\"diff-del\">this is the first paragraph</p><p>this is the second paragraph</p></div><div class=\"span8 offset1\"><p>this is the second paragraph</p></div>"
+ end
+
+ end
+
+ describe "side_by_side_markdown" do
+
+ it "returns an empty table when no content is diffed" do
+ DiscourseDiff.new("", "").side_by_side_markdown.should == "<table class=\"markdown\"></table>"
+ end
+
+ it "properly escape html tags" do
+ before = ""
+ after = "<img src=\"//domain.com/image.png>\""
+ DiscourseDiff.new(before, after).side_by_side_markdown.should == "<table class=\"markdown\"><tr><td></td><td class=\"diff-ins\"><img src="//domain.com/image.png>"</td></tr></table>"
+ end
+
+ it "returns the diffed content on both columns when there is no difference" do
+ before = after = "this is a paragraph"
+ DiscourseDiff.new(before, after).side_by_side_markdown.should == "<table class=\"markdown\"><tr><td>this is a paragraph</td><td>this is a paragraph</td></tr></table>"
+ end
+
+ it "adds <ins> tags around added text on the second column" do
+ before = "this is a paragraph"
+ after = "this is a great paragraph"
+ DiscourseDiff.new(before, after).side_by_side_markdown.should == "<table class=\"markdown\"><tr><td class=\"diff-del\">this is a paragraph</td><td class=\"diff-ins\">this is a <ins>great </ins>paragraph</td></tr></table>"
+ end
+
+ it "adds <del> tags around removed text on the first column" do
+ before = "this is a great paragraph"
+ after = "this is a paragraph"
+ DiscourseDiff.new(before, after).side_by_side_markdown.should == "<table class=\"markdown\"><tr><td class=\"diff-del\">this is a <del>great </del>paragraph</td><td class=\"diff-ins\">this is a paragraph</td></tr></table>"
+ end
+
+ it "adds .diff-ins class when a paragraph is added" do
+ before = "this is the first paragraph"
+ after = "this is the first paragraph\nthis is the second paragraph"
+ DiscourseDiff.new(before, after).side_by_side_markdown.should == "<table class=\"markdown\"><tr><td class=\"diff-del\">this is the first paragraph</td><td class=\"diff-ins\">this is the first paragraph<ins>\nthis is the second paragraph</ins></td></tr></table>"
+ end
+
+ it "adds .diff-del class when a paragraph is removed" do
+ before = "this is the first paragraph\nthis is the second paragraph"
+ after = "this is the second paragraph"
+ DiscourseDiff.new(before, after).side_by_side_markdown.should == "<table class=\"markdown\"><tr><td class=\"diff-del\">this is the first paragraph\n</td><td></td></tr><tr><td>this is the second paragraph</td><td>this is the second paragraph</td></tr></table>"
+ end
+
+ end
+
+end
+