From 0784c52a24f5ff743d3c3290e4fcbc05b0b37176 Mon Sep 17 00:00:00 2001 From: cpradio Date: Thu, 28 Aug 2014 21:39:19 -0400 Subject: [PATCH] FIX: Remove up/down key bindings for search results Up/down key bindings make it difficult to access Show More on search results. https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394 --- .../views/search-results-type.js.es6 | 3 +-- .../javascripts/discourse/views/search.js.es6 | 23 ------------------- 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/app/assets/javascripts/discourse/views/search-results-type.js.es6 b/app/assets/javascripts/discourse/views/search-results-type.js.es6 index b77d523c0..9f88257d8 100644 --- a/app/assets/javascripts/discourse/views/search-results-type.js.es6 +++ b/app/assets/javascripts/discourse/views/search-results-type.js.es6 @@ -3,7 +3,6 @@ export default Ember.CollectionView.extend({ itemViewClass: Discourse.GroupedView.extend({ tagName: 'li', classNameBindings: ['selected'], - templateName: Discourse.computed.fmt('parentView.type', "search/%@_result"), - selected: Discourse.computed.propertyEqual('content.index', 'controller.selectedIndex') + templateName: Discourse.computed.fmt('parentView.type', "search/%@_result") }) }); diff --git a/app/assets/javascripts/discourse/views/search.js.es6 b/app/assets/javascripts/discourse/views/search.js.es6 index 115d6fe1f..92490c1a7 100644 --- a/app/assets/javascripts/discourse/views/search.js.es6 +++ b/app/assets/javascripts/discourse/views/search.js.es6 @@ -3,27 +3,4 @@ export default Discourse.View.extend({ classNames: ['d-dropdown'], elementId: 'search-dropdown', templateName: 'search' - -// didInsertElement: function() { -// // Delegate ESC to the composer -// var controller = this.get('controller'); -// return $('body').on('keydown.search', function(e) { -// if ($('#search-dropdown').is(':visible')) { -// switch (e.which) { -// case 13: -// controller.select(); -// e.preventDefault(); -// break; -// case 38: -// controller.moveUp(); -// e.preventDefault(); -// break; -// case 40: -// controller.moveDown(); -// e.preventDefault(); -// break; -// } -// } -// }); -// } });