2013-02-05 14:16:51 -05:00
require 'spec_helper'
2013-03-18 17:52:29 -04:00
require_dependency 'post_destroyer'
2013-02-05 14:16:51 -05:00
describe Post do
2013-06-19 03:19:42 -04:00
before { Oneboxer . stubs :onebox }
2013-05-10 16:58:23 -04:00
# Help us build a post with a raw body
def post_with_body ( body , user = nil )
args = post_args . merge ( raw : body )
args [ :user ] = user if user . present?
Fabricate . build ( :post , args )
end
2015-01-05 11:04:23 -05:00
it { is_expected . to validate_presence_of :raw }
2013-02-05 14:16:51 -05:00
# Min/max body lengths, respecting padding
2015-01-05 11:04:23 -05:00
it { is_expected . not_to allow_value ( " x " ) . for ( :raw ) }
it { is_expected . not_to allow_value ( " x " * ( SiteSetting . max_post_length + 1 ) ) . for ( :raw ) }
it { is_expected . not_to allow_value ( ( " " * SiteSetting . min_post_length ) + " x " ) . for ( :raw ) }
2013-02-05 14:16:51 -05:00
2015-01-05 11:04:23 -05:00
it { is_expected . to rate_limit }
2013-02-05 14:16:51 -05:00
let ( :topic ) { Fabricate ( :topic ) }
let ( :post_args ) do
2013-12-11 21:41:34 -05:00
{ user : topic . user , topic : topic }
2013-02-05 14:16:51 -05:00
end
2013-02-21 13:20:00 -05:00
describe 'scopes' do
describe '#by_newest' do
it 'returns posts ordered by created_at desc' do
2013-08-20 15:45:58 -04:00
2 . times do | t |
Fabricate ( :post , created_at : t . seconds . from_now )
end
2015-01-05 11:04:23 -05:00
expect ( Post . by_newest . first . created_at ) . to be > Post . by_newest . last . created_at
2013-02-21 13:20:00 -05:00
end
end
describe '#with_user' do
it 'gives you a user' do
2013-06-25 10:15:41 -04:00
Fabricate ( :post , user : Fabricate . build ( :user ) )
2015-01-05 11:04:23 -05:00
expect ( Post . with_user . first . user ) . to be_a User
2013-02-21 13:20:00 -05:00
end
end
end
2013-12-11 21:41:34 -05:00
describe " revisions and deleting/recovery " do
2013-03-13 12:35:55 -04:00
2013-06-13 13:41:45 -04:00
context 'a post without links' do
let ( :post ) { Fabricate ( :post , post_args ) }
before do
post . trash!
post . reload
end
2013-03-13 12:35:55 -04:00
2013-12-11 21:41:34 -05:00
it " doesn't create a new revision when deleted " do
2015-01-05 11:04:23 -05:00
expect ( post . revisions . count ) . to eq ( 0 )
2013-06-13 13:41:45 -04:00
end
describe " recovery " do
before do
post . recover!
post . reload
end
2013-12-11 21:41:34 -05:00
it " doesn't create a new revision when recovered " do
2015-01-05 11:04:23 -05:00
expect ( post . revisions . count ) . to eq ( 0 )
2013-06-13 13:41:45 -04:00
end
end
2013-03-13 12:35:55 -04:00
end
2013-06-13 13:41:45 -04:00
context 'a post with links' do
let ( :post ) { Fabricate ( :post_with_external_links ) }
2013-03-13 12:35:55 -04:00
before do
2013-06-13 13:41:45 -04:00
post . trash!
2013-03-13 12:35:55 -04:00
post . reload
end
2013-06-13 13:41:45 -04:00
describe 'recovery' do
it 'recreates the topic_link records' do
TopicLink . expects ( :extract_from ) . with ( post )
post . recover!
end
2013-03-13 12:35:55 -04:00
end
end
end
2013-02-25 11:42:20 -05:00
describe 'flagging helpers' do
it 'isFlagged is accurate' do
2013-02-06 23:15:48 -05:00
post = Fabricate ( :post )
user = Fabricate ( :coding_horror )
2013-03-01 07:07:44 -05:00
PostAction . act ( user , post , PostActionType . types [ :off_topic ] )
2013-02-06 23:15:48 -05:00
2013-02-25 11:42:20 -05:00
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . is_flagged? ) . to eq ( true )
2013-02-25 11:42:20 -05:00
2013-03-01 07:07:44 -05:00
PostAction . remove_act ( user , post , PostActionType . types [ :off_topic ] )
2013-02-25 11:42:20 -05:00
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . is_flagged? ) . to eq ( false )
2013-02-06 23:15:48 -05:00
end
end
2013-02-05 14:16:51 -05:00
describe " maximum images " do
2014-09-05 01:20:39 -04:00
let ( :newuser ) { Fabricate ( :user , trust_level : TrustLevel [ 0 ] ) }
2013-04-17 19:11:13 -04:00
let ( :post_no_images ) { Fabricate . build ( :post , post_args . merge ( user : newuser ) ) }
2013-05-10 16:58:23 -04:00
let ( :post_one_image ) { post_with_body ( " ![sherlock](http://bbc.co.uk/sherlock.jpg) " , newuser ) }
let ( :post_two_images ) { post_with_body ( " <img src='http://discourse.org/logo.png'> <img src='http://bbc.co.uk/sherlock.jpg'> " , newuser ) }
let ( :post_with_avatars ) { post_with_body ( '<img alt="smiley" title=":smiley:" src="/assets/emoji/smiley.png" class="avatar"> <img alt="wink" title=":wink:" src="/assets/emoji/wink.png" class="avatar">' , newuser ) }
let ( :post_with_favicon ) { post_with_body ( '<img src="/assets/favicons/wikipedia.png" class="favicon">' , newuser ) }
let ( :post_with_thumbnail ) { post_with_body ( '<img src="/assets/emoji/smiley.png" class="thumbnail">' , newuser ) }
let ( :post_with_two_classy_images ) { post_with_body ( " <img src='http://discourse.org/logo.png' class='classy'> <img src='http://bbc.co.uk/sherlock.jpg' class='classy'> " , newuser ) }
2013-02-05 14:16:51 -05:00
it " returns 0 images for an empty post " do
2015-01-05 11:04:23 -05:00
expect ( Fabricate . build ( :post ) . image_count ) . to eq ( 0 )
2013-02-05 14:16:51 -05:00
end
it " finds images from markdown " do
2015-01-05 11:04:23 -05:00
expect ( post_one_image . image_count ) . to eq ( 1 )
2013-02-05 14:16:51 -05:00
end
it " finds images from HTML " do
2015-01-05 11:04:23 -05:00
expect ( post_two_images . image_count ) . to eq ( 2 )
2013-02-05 14:16:51 -05:00
end
2013-02-12 02:43:48 -05:00
it " doesn't count avatars as images " do
2015-01-05 11:04:23 -05:00
expect ( post_with_avatars . image_count ) . to eq ( 0 )
2013-02-05 14:16:51 -05:00
end
2013-04-11 12:36:45 -04:00
it " doesn't count favicons as images " do
2015-01-05 11:04:23 -05:00
expect ( post_with_favicon . image_count ) . to eq ( 0 )
2013-04-11 12:36:45 -04:00
end
it " doesn't count thumbnails as images " do
2015-01-05 11:04:23 -05:00
expect ( post_with_thumbnail . image_count ) . to eq ( 0 )
2013-04-11 12:36:45 -04:00
end
2013-02-12 02:43:48 -05:00
it " doesn't count whitelisted images " do
2013-02-25 11:42:20 -05:00
Post . stubs ( :white_listed_image_classes ) . returns ( [ " classy " ] )
2015-01-05 11:04:23 -05:00
expect ( post_with_two_classy_images . image_count ) . to eq ( 0 )
2013-02-12 02:43:48 -05:00
end
2013-02-05 14:16:51 -05:00
context " validation " do
2013-03-25 12:24:46 -04:00
before do
2013-04-17 19:11:13 -04:00
SiteSetting . stubs ( :newuser_max_images ) . returns ( 1 )
2013-02-05 14:16:51 -05:00
end
2013-04-17 19:11:13 -04:00
context 'newuser' do
it " allows a new user to post below the limit " do
2015-01-05 11:04:23 -05:00
expect ( post_one_image ) . to be_valid
2013-03-25 12:24:46 -04:00
end
it " doesn't allow more than the maximum " do
2015-01-05 11:04:23 -05:00
expect ( post_two_images ) . not_to be_valid
2013-03-25 12:24:46 -04:00
end
2013-04-17 19:11:13 -04:00
it " doesn't allow a new user to edit their post to insert an image " do
2014-09-05 01:20:39 -04:00
post_no_images . user . trust_level = TrustLevel [ 0 ]
2013-03-25 12:24:46 -04:00
post_no_images . save
2015-01-05 11:04:23 -05:00
expect {
2014-10-27 17:06:43 -04:00
post_no_images . revise ( post_no_images . user , { raw : post_two_images . raw } )
2013-03-25 12:24:46 -04:00
post_no_images . reload
2015-01-05 11:04:23 -05:00
} . not_to change ( post_no_images , :raw )
2013-03-25 12:24:46 -04:00
end
2013-02-05 14:16:51 -05:00
end
2013-04-17 19:11:13 -04:00
it " allows more images from a not-new account " do
2014-09-05 01:20:39 -04:00
post_two_images . user . trust_level = TrustLevel [ 1 ]
2015-01-05 11:04:23 -05:00
expect ( post_two_images ) . to be_valid
2013-02-05 14:16:51 -05:00
end
end
end
2013-07-21 20:39:17 -04:00
describe " maximum attachments " do
2014-09-05 01:20:39 -04:00
let ( :newuser ) { Fabricate ( :user , trust_level : TrustLevel [ 0 ] ) }
2013-07-21 20:39:17 -04:00
let ( :post_no_attachments ) { Fabricate . build ( :post , post_args . merge ( user : newuser ) ) }
let ( :post_one_attachment ) { post_with_body ( '<a class="attachment" href="/uploads/default/1/2082985.txt">file.txt</a>' , newuser ) }
let ( :post_two_attachments ) { post_with_body ( '<a class="attachment" href="/uploads/default/2/20947092.log">errors.log</a> <a class="attachment" href="/uploads/default/3/283572385.3ds">model.3ds</a>' , newuser ) }
it " returns 0 attachments for an empty post " do
2015-01-05 11:04:23 -05:00
expect ( Fabricate . build ( :post ) . attachment_count ) . to eq ( 0 )
2013-07-21 20:39:17 -04:00
end
it " finds attachments from HTML " do
2015-01-05 11:04:23 -05:00
expect ( post_two_attachments . attachment_count ) . to eq ( 2 )
2013-07-21 20:39:17 -04:00
end
context " validation " do
before do
SiteSetting . stubs ( :newuser_max_attachments ) . returns ( 1 )
end
context 'newuser' do
it " allows a new user to post below the limit " do
2015-01-05 11:04:23 -05:00
expect ( post_one_attachment ) . to be_valid
2013-07-21 20:39:17 -04:00
end
it " doesn't allow more than the maximum " do
2015-01-05 11:04:23 -05:00
expect ( post_two_attachments ) . not_to be_valid
2013-07-21 20:39:17 -04:00
end
it " doesn't allow a new user to edit their post to insert an attachment " do
2014-09-05 01:20:39 -04:00
post_no_attachments . user . trust_level = TrustLevel [ 0 ]
2013-07-21 20:39:17 -04:00
post_no_attachments . save
2015-01-05 11:04:23 -05:00
expect {
2014-10-27 17:06:43 -04:00
post_no_attachments . revise ( post_no_attachments . user , { raw : post_two_attachments . raw } )
2013-07-21 20:39:17 -04:00
post_no_attachments . reload
2015-01-05 11:04:23 -05:00
} . not_to change ( post_no_attachments , :raw )
2013-07-21 20:39:17 -04:00
end
end
it " allows more attachments from a not-new account " do
2014-09-05 01:20:39 -04:00
post_two_attachments . user . trust_level = TrustLevel [ 1 ]
2015-01-05 11:04:23 -05:00
expect ( post_two_attachments ) . to be_valid
2013-07-21 20:39:17 -04:00
end
end
end
2013-05-10 16:58:23 -04:00
context " links " do
2014-09-05 01:20:39 -04:00
let ( :newuser ) { Fabricate ( :user , trust_level : TrustLevel [ 0 ] ) }
2013-05-10 16:58:23 -04:00
let ( :no_links ) { post_with_body ( " hello world my name is evil trout " , newuser ) }
let ( :one_link ) { post_with_body ( " [jlawr](http://www.imdb.com/name/nm2225369) " , newuser ) }
let ( :two_links ) { post_with_body ( " <a href='http://disneyland.disney.go.com/'>disney</a> <a href='http://reddit.com'>reddit</a> " , newuser ) }
let ( :three_links ) { post_with_body ( " http://discourse.org and http://discourse.org/another_url and http://www.imdb.com/name/nm2225369 " , newuser ) }
describe " raw_links " do
it " returns a blank collection for a post with no links " do
2015-01-05 11:04:23 -05:00
expect ( no_links . raw_links ) . to be_blank
2013-05-10 16:58:23 -04:00
end
it " finds a link within markdown " do
2015-01-05 11:04:23 -05:00
expect ( one_link . raw_links ) . to eq ( [ " http://www.imdb.com/name/nm2225369 " ] )
2013-05-10 16:58:23 -04:00
end
it " can find two links from html " do
2015-01-05 11:04:23 -05:00
expect ( two_links . raw_links ) . to eq ( [ " http://disneyland.disney.go.com/ " , " http://reddit.com " ] )
2013-05-10 16:58:23 -04:00
end
it " can find three links without markup " do
2015-01-05 11:04:23 -05:00
expect ( three_links . raw_links ) . to eq ( [ " http://discourse.org " , " http://discourse.org/another_url " , " http://www.imdb.com/name/nm2225369 " ] )
2013-05-10 16:58:23 -04:00
end
end
describe " linked_hosts " do
it " returns blank with no links " do
2015-01-05 11:04:23 -05:00
expect ( no_links . linked_hosts ) . to be_blank
2013-05-10 16:58:23 -04:00
end
it " returns the host and a count for links " do
2015-01-05 11:04:23 -05:00
expect ( two_links . linked_hosts ) . to eq ( { " disneyland.disney.go.com " = > 1 , " reddit.com " = > 1 } )
2013-05-10 16:58:23 -04:00
end
it " it counts properly with more than one link on the same host " do
2015-01-05 11:04:23 -05:00
expect ( three_links . linked_hosts ) . to eq ( { " discourse.org " = > 1 , " www.imdb.com " = > 1 } )
2013-05-10 16:58:23 -04:00
end
end
describe " total host usage " do
it " has none for a regular post " do
2015-01-05 11:04:23 -05:00
expect ( no_links . total_hosts_usage ) . to be_blank
2013-05-10 16:58:23 -04:00
end
context " with a previous host " do
let ( :user ) { old_post . newuser }
let ( :another_disney_link ) { post_with_body ( " [radiator springs](http://disneyland.disney.go.com/disney-california-adventure/radiator-springs-racers/) " , newuser ) }
before do
another_disney_link . save
TopicLink . extract_from ( another_disney_link )
end
it " contains the new post's links, PLUS the previous one " do
2015-01-05 11:04:23 -05:00
expect ( two_links . total_hosts_usage ) . to eq ( { 'disneyland.disney.go.com' = > 2 , 'reddit.com' = > 1 } )
2013-05-10 16:58:23 -04:00
end
end
end
end
2013-02-05 14:16:51 -05:00
describe " maximum links " do
2014-09-05 01:20:39 -04:00
let ( :newuser ) { Fabricate ( :user , trust_level : TrustLevel [ 0 ] ) }
2013-05-10 16:58:23 -04:00
let ( :post_one_link ) { post_with_body ( " [sherlock](http://www.bbc.co.uk/programmes/b018ttws) " , newuser ) }
let ( :post_two_links ) { post_with_body ( " <a href='http://discourse.org'>discourse</a> <a href='http://twitter.com'>twitter</a> " , newuser ) }
let ( :post_with_mentions ) { post_with_body ( " hello @ #{ newuser . username } how are you doing? " , newuser ) }
2013-02-05 14:16:51 -05:00
2013-03-25 13:12:15 -04:00
it " returns 0 links for an empty post " do
2015-01-05 11:04:23 -05:00
expect ( Fabricate . build ( :post ) . link_count ) . to eq ( 0 )
2013-02-05 14:16:51 -05:00
end
2013-03-25 13:12:15 -04:00
it " returns 0 links for a post with mentions " do
2015-01-05 11:04:23 -05:00
expect ( post_with_mentions . link_count ) . to eq ( 0 )
2013-03-25 13:12:15 -04:00
end
it " finds links from markdown " do
2015-01-05 11:04:23 -05:00
expect ( post_one_link . link_count ) . to eq ( 1 )
2013-02-05 14:16:51 -05:00
end
2013-03-25 13:12:15 -04:00
it " finds links from HTML " do
2015-01-05 11:04:23 -05:00
expect ( post_two_links . link_count ) . to eq ( 2 )
2013-02-05 14:16:51 -05:00
end
context " validation " do
2013-03-25 12:24:46 -04:00
before do
2013-04-17 19:11:13 -04:00
SiteSetting . stubs ( :newuser_max_links ) . returns ( 1 )
2013-02-05 14:16:51 -05:00
end
2013-04-17 19:11:13 -04:00
context 'newuser' do
2013-03-25 12:24:46 -04:00
it " returns true when within the amount of links allowed " do
2015-01-05 11:04:23 -05:00
expect ( post_one_link ) . to be_valid
2013-03-25 12:24:46 -04:00
end
it " doesn't allow more links than allowed " do
2015-01-05 11:04:23 -05:00
expect ( post_two_links ) . not_to be_valid
2013-03-25 12:24:46 -04:00
end
2013-02-05 14:16:51 -05:00
end
it " allows multiple images for basic accounts " do
2014-09-05 01:20:39 -04:00
post_two_links . user . trust_level = TrustLevel [ 1 ]
2015-01-05 11:04:23 -05:00
expect ( post_two_links ) . to be_valid
2013-02-05 14:16:51 -05:00
end
2013-03-25 12:24:46 -04:00
2013-02-05 14:16:51 -05:00
end
end
2013-03-25 12:24:46 -04:00
describe " @mentions " do
2013-02-05 14:16:51 -05:00
context 'raw_mentions' do
it " returns an empty array with no matches " do
post = Fabricate . build ( :post , post_args . merge ( raw : " Hello Jake and Finn! " ) )
2015-01-05 11:04:23 -05:00
expect ( post . raw_mentions ) . to eq ( [ ] )
2013-02-05 14:16:51 -05:00
end
it " returns lowercase unique versions of the mentions " do
post = Fabricate . build ( :post , post_args . merge ( raw : " @Jake @Finn @Jake " ) )
2015-01-05 11:04:23 -05:00
expect ( post . raw_mentions ) . to eq ( [ 'jake' , 'finn' ] )
2013-02-05 14:16:51 -05:00
end
it " ignores pre " do
post = Fabricate . build ( :post , post_args . merge ( raw : " <pre>@Jake</pre> @Finn " ) )
2015-01-05 11:04:23 -05:00
expect ( post . raw_mentions ) . to eq ( [ 'finn' ] )
2013-02-05 14:16:51 -05:00
end
it " catches content between pre tags " do
post = Fabricate . build ( :post , post_args . merge ( raw : " <pre>hello</pre> @Finn <pre></pre> " ) )
2015-01-05 11:04:23 -05:00
expect ( post . raw_mentions ) . to eq ( [ 'finn' ] )
2013-02-05 14:16:51 -05:00
end
it " ignores code " do
2013-09-11 15:52:37 -04:00
post = Fabricate . build ( :post , post_args . merge ( raw : " @Jake `@Finn` " ) )
2015-01-05 11:04:23 -05:00
expect ( post . raw_mentions ) . to eq ( [ 'jake' ] )
2013-02-25 11:42:20 -05:00
end
2013-02-05 14:16:51 -05:00
it " ignores quotes " do
post = Fabricate . build ( :post , post_args . merge ( raw : " [quote= \" Evil Trout \" ]@Jake[/quote] @Finn " ) )
2015-01-05 11:04:23 -05:00
expect ( post . raw_mentions ) . to eq ( [ 'finn' ] )
2013-02-25 11:42:20 -05:00
end
2013-02-05 14:16:51 -05:00
2013-03-23 20:57:00 -04:00
it " handles underscore in username " do
post = Fabricate . build ( :post , post_args . merge ( raw : " @Jake @Finn @Jake_Old " ) )
2015-01-05 11:04:23 -05:00
expect ( post . raw_mentions ) . to eq ( [ 'jake' , 'finn' , 'jake_old' ] )
2013-03-23 20:57:00 -04:00
end
2013-02-05 14:16:51 -05:00
end
2013-03-25 12:24:46 -04:00
context " max mentions " do
2014-09-05 01:20:39 -04:00
let ( :newuser ) { Fabricate ( :user , trust_level : TrustLevel [ 0 ] ) }
2013-05-10 16:58:23 -04:00
let ( :post_with_one_mention ) { post_with_body ( " @Jake is the person I'm mentioning " , newuser ) }
let ( :post_with_two_mentions ) { post_with_body ( " @Jake @Finn are the people I'm mentioning " , newuser ) }
2013-03-25 12:24:46 -04:00
2013-04-17 19:11:13 -04:00
context 'new user' do
2013-03-25 12:24:46 -04:00
before do
2013-04-17 19:11:13 -04:00
SiteSetting . stubs ( :newuser_max_mentions_per_post ) . returns ( 1 )
2013-03-25 12:24:46 -04:00
SiteSetting . stubs ( :max_mentions_per_post ) . returns ( 5 )
end
2013-04-17 19:11:13 -04:00
it " allows a new user to have newuser_max_mentions_per_post mentions " do
2015-01-05 11:04:23 -05:00
expect ( post_with_one_mention ) . to be_valid
2013-03-25 12:24:46 -04:00
end
2013-04-17 19:11:13 -04:00
it " doesn't allow a new user to have more than newuser_max_mentions_per_post mentions " do
2015-01-05 11:04:23 -05:00
expect ( post_with_two_mentions ) . not_to be_valid
2013-03-25 12:24:46 -04:00
end
2013-02-05 14:16:51 -05:00
end
2013-04-17 19:11:13 -04:00
context " not a new user " do
2013-03-25 12:24:46 -04:00
before do
2013-04-17 19:11:13 -04:00
SiteSetting . stubs ( :newuser_max_mentions_per_post ) . returns ( 0 )
2013-03-25 12:24:46 -04:00
SiteSetting . stubs ( :max_mentions_per_post ) . returns ( 1 )
end
it " allows vmax_mentions_per_post mentions " do
2014-09-05 01:20:39 -04:00
post_with_one_mention . user . trust_level = TrustLevel [ 1 ]
2015-01-05 11:04:23 -05:00
expect ( post_with_one_mention ) . to be_valid
2013-03-25 12:24:46 -04:00
end
it " doesn't allow to have more than max_mentions_per_post mentions " do
2014-09-05 01:20:39 -04:00
post_with_two_mentions . user . trust_level = TrustLevel [ 1 ]
2015-01-05 11:04:23 -05:00
expect ( post_with_two_mentions ) . not_to be_valid
2013-03-25 12:24:46 -04:00
end
2013-02-05 14:16:51 -05:00
end
2013-03-25 12:24:46 -04:00
2013-02-05 14:16:51 -05:00
end
end
2013-06-13 04:18:17 -04:00
context 'validation' do
it 'validates our default post' do
2015-01-05 11:04:23 -05:00
expect ( Fabricate . build ( :post , post_args ) ) . to be_valid
2013-06-13 04:18:17 -04:00
end
it 'treate blank posts as invalid' do
2015-01-05 11:04:23 -05:00
expect ( Fabricate . build ( :post , raw : " " ) ) . not_to be_valid
2013-06-13 04:18:17 -04:00
end
2013-02-05 14:16:51 -05:00
end
context " raw_hash " do
let ( :raw ) { " this is our test post body " }
2013-05-10 16:58:23 -04:00
let ( :post ) { post_with_body ( raw ) }
2013-02-25 11:42:20 -05:00
2013-02-05 14:16:51 -05:00
it " returns a value " do
2015-01-05 11:04:23 -05:00
expect ( post . raw_hash ) . to be_present
2013-02-05 14:16:51 -05:00
end
it " returns blank for a nil body " do
post . raw = nil
2015-01-05 11:04:23 -05:00
expect ( post . raw_hash ) . to be_blank
2013-02-05 14:16:51 -05:00
end
it " returns the same value for the same raw " do
2015-01-05 11:04:23 -05:00
expect ( post . raw_hash ) . to eq ( post_with_body ( raw ) . raw_hash )
2013-02-05 14:16:51 -05:00
end
it " returns a different value for a different raw " do
2015-01-05 11:04:23 -05:00
expect ( post . raw_hash ) . not_to eq ( post_with_body ( " something else " ) . raw_hash )
2013-02-05 14:16:51 -05:00
end
2013-06-17 15:57:13 -04:00
it " returns a different value with different text case " do
2015-01-05 11:04:23 -05:00
expect ( post . raw_hash ) . not_to eq ( post_with_body ( " THIS is OUR TEST post BODy " ) . raw_hash )
2013-02-05 14:16:51 -05:00
end
end
context 'revise' do
let ( :post ) { Fabricate ( :post , post_args ) }
let ( :first_version_at ) { post . last_version_at }
2013-12-11 21:41:34 -05:00
it 'has no revision' do
2015-01-05 11:04:23 -05:00
expect ( post . revisions . size ) . to eq ( 0 )
expect ( first_version_at ) . to be_present
expect ( post . revise ( post . user , { raw : post . raw } ) ) . to eq ( false )
2013-02-05 14:16:51 -05:00
end
2013-04-22 03:45:03 -04:00
describe 'with the same body' do
2013-12-11 21:41:34 -05:00
it " doesn't change version " do
2015-01-05 11:04:23 -05:00
expect { post . revise ( post . user , { raw : post . raw } ) ; post . reload } . not_to change ( post , :version )
2013-02-05 14:16:51 -05:00
end
end
2014-10-27 17:06:43 -04:00
describe 'ninja editing & edit windows' do
2013-02-05 14:16:51 -05:00
2014-10-27 17:06:43 -04:00
before { SiteSetting . stubs ( :ninja_edit_window ) . returns ( 1 . minute . to_i ) }
2013-04-30 08:54:30 -04:00
2014-10-27 17:06:43 -04:00
it 'works' do
revised_at = post . updated_at + 2 . minutes
new_revised_at = revised_at + 2 . minutes
2013-02-05 14:16:51 -05:00
2014-10-27 17:06:43 -04:00
# ninja edit
post . revise ( post . user , { raw : 'updated body' } , revised_at : post . updated_at + 10 . seconds )
2013-02-05 14:16:51 -05:00
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . version ) . to eq ( 1 )
expect ( post . public_version ) . to eq ( 1 )
expect ( post . revisions . size ) . to eq ( 0 )
expect ( post . last_version_at . to_i ) . to eq ( first_version_at . to_i )
2013-02-05 14:16:51 -05:00
2014-10-27 17:06:43 -04:00
# revision much later
post . revise ( post . user , { raw : 'another updated body' } , revised_at : revised_at )
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . version ) . to eq ( 2 )
expect ( post . public_version ) . to eq ( 2 )
expect ( post . revisions . size ) . to eq ( 1 )
expect ( post . last_version_at . to_i ) . to eq ( revised_at . to_i )
2013-02-05 14:16:51 -05:00
2014-10-27 17:06:43 -04:00
# new edit window
post . revise ( post . user , { raw : 'yet another updated body' } , revised_at : revised_at + 10 . seconds )
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . version ) . to eq ( 2 )
expect ( post . public_version ) . to eq ( 2 )
expect ( post . revisions . size ) . to eq ( 1 )
expect ( post . last_version_at . to_i ) . to eq ( revised_at . to_i )
2013-02-05 14:16:51 -05:00
2014-10-27 17:06:43 -04:00
# after second window
post . revise ( post . user , { raw : 'yet another, another updated body' } , revised_at : new_revised_at )
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . version ) . to eq ( 3 )
expect ( post . public_version ) . to eq ( 3 )
expect ( post . revisions . size ) . to eq ( 2 )
expect ( post . last_version_at . to_i ) . to eq ( new_revised_at . to_i )
2013-02-05 14:16:51 -05:00
end
end
describe 'rate limiter' do
let ( :changed_by ) { Fabricate ( :coding_horror ) }
2013-02-25 11:42:20 -05:00
2013-02-05 14:16:51 -05:00
it " triggers a rate limiter " do
2013-02-09 10:33:07 -05:00
EditRateLimiter . any_instance . expects ( :performed! )
2014-10-27 17:06:43 -04:00
post . revise ( changed_by , { raw : 'updated body' } )
2013-02-05 14:16:51 -05:00
end
end
describe 'with a new body' do
let ( :changed_by ) { Fabricate ( :coding_horror ) }
2014-10-27 17:06:43 -04:00
let! ( :result ) { post . revise ( changed_by , { raw : 'updated body' } ) }
2013-02-05 14:16:51 -05:00
2013-04-22 03:45:03 -04:00
it 'acts correctly' do
2015-01-05 11:04:23 -05:00
expect ( result ) . to eq ( true )
expect ( post . raw ) . to eq ( 'updated body' )
expect ( post . invalidate_oneboxes ) . to eq ( true )
expect ( post . version ) . to eq ( 2 )
expect ( post . public_version ) . to eq ( 2 )
expect ( post . revisions . size ) . to eq ( 1 )
expect ( post . revisions . first . user ) . to be_present
2013-02-05 14:16:51 -05:00
end
context 'second poster posts again quickly' do
2014-10-27 17:06:43 -04:00
it 'is a ninja edit, because the second poster posted again quickly' do
2013-02-05 14:16:51 -05:00
SiteSetting . expects ( :ninja_edit_window ) . returns ( 1 . minute . to_i )
2014-10-27 17:06:43 -04:00
post . revise ( changed_by , { raw : 'yet another updated body' } , revised_at : post . updated_at + 10 . seconds )
2013-02-05 14:16:51 -05:00
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . version ) . to eq ( 2 )
expect ( post . public_version ) . to eq ( 2 )
expect ( post . revisions . size ) . to eq ( 1 )
2013-02-25 11:42:20 -05:00
end
2013-02-05 14:16:51 -05:00
end
end
2014-10-27 17:06:43 -04:00
2013-02-05 14:16:51 -05:00
end
describe 'after save' do
let ( :post ) { Fabricate ( :post , post_args ) }
2013-04-22 03:45:03 -04:00
it " has correct info set " do
2015-01-05 11:04:23 -05:00
expect ( post . user_deleted? ) . to eq ( false )
expect ( post . post_number ) . to be_present
expect ( post . excerpt ) . to be_present
expect ( post . post_type ) . to eq ( Post . types [ :regular ] )
expect ( post . revisions ) . to be_blank
expect ( post . cooked ) . to be_present
expect ( post . external_id ) . to be_present
expect ( post . quote_count ) . to eq ( 0 )
expect ( post . replies ) . to be_blank
2013-02-05 14:16:51 -05:00
end
2013-03-18 15:54:08 -04:00
describe 'extract_quoted_post_numbers' do
2013-02-05 14:16:51 -05:00
let! ( :post ) { Fabricate ( :post , post_args ) }
let ( :reply ) { Fabricate . build ( :post , post_args ) }
it " finds the quote when in the same topic " do
reply . raw = " [quote= \" EvilTrout, post: #{ post . post_number } , topic: #{ post . topic_id } \" ]hello[/quote] "
reply . extract_quoted_post_numbers
2015-01-05 11:04:23 -05:00
expect ( reply . quoted_post_numbers ) . to eq ( [ post . post_number ] )
2013-02-05 14:16:51 -05:00
end
it " doesn't find the quote in a different topic " do
reply . raw = " [quote= \" EvilTrout, post: #{ post . post_number } , topic: #{ post . topic_id + 1 } \" ]hello[/quote] "
reply . extract_quoted_post_numbers
2015-01-05 11:04:23 -05:00
expect ( reply . quoted_post_numbers ) . to be_blank
2013-02-05 14:16:51 -05:00
end
end
describe 'a new reply' do
2013-03-18 15:54:08 -04:00
let ( :topic ) { Fabricate ( :topic ) }
let ( :other_user ) { Fabricate ( :coding_horror ) }
let ( :reply_text ) { " [quote= \" Evil Trout, post:1 \" ] \n hello \n [/quote] \n Hmmm! " }
let! ( :post ) { PostCreator . new ( topic . user , raw : Fabricate . build ( :post ) . raw , topic_id : topic . id ) . create }
let! ( :reply ) { PostCreator . new ( other_user , raw : reply_text , topic_id : topic . id , reply_to_post_number : post . post_number ) . create }
2013-02-05 14:16:51 -05:00
it 'has a quote' do
2015-01-05 11:04:23 -05:00
expect ( reply . quote_count ) . to eq ( 1 )
2013-02-05 14:16:51 -05:00
end
it 'has a reply to the user of the original user' do
2015-01-05 11:04:23 -05:00
expect ( reply . reply_to_user ) . to eq ( post . user )
2013-02-05 14:16:51 -05:00
end
it 'increases the reply count of the parent' do
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . reply_count ) . to eq ( 1 )
2013-02-05 14:16:51 -05:00
end
it 'increases the reply count of the topic' do
topic . reload
2015-01-05 11:04:23 -05:00
expect ( topic . reply_count ) . to eq ( 1 )
2013-02-05 14:16:51 -05:00
end
it 'is the child of the parent post' do
2015-01-05 11:04:23 -05:00
expect ( post . replies ) . to eq ( [ reply ] )
2013-02-05 14:16:51 -05:00
end
it " doesn't change the post count when you edit the reply " do
reply . raw = 'updated raw'
reply . save
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . reply_count ) . to eq ( 1 )
2013-02-05 14:16:51 -05:00
end
context 'a multi-quote reply' do
2013-03-18 15:54:08 -04:00
let! ( :multi_reply ) do
raw = " [quote= \" Evil Trout, post:1 \" ]post1 quote[/quote] \n Aha! \n [quote= \" Evil Trout, post:2 \" ]post2 quote[/quote] \n Neat-o "
PostCreator . new ( other_user , raw : raw , topic_id : topic . id , reply_to_post_number : post . post_number ) . create
end
2013-02-05 14:16:51 -05:00
2013-04-22 03:45:03 -04:00
it 'has the correct info set' do
2015-01-05 11:04:23 -05:00
expect ( multi_reply . quote_count ) . to eq ( 2 )
expect ( post . replies . include? ( multi_reply ) ) . to eq ( true )
expect ( reply . replies . include? ( multi_reply ) ) . to eq ( true )
2013-02-05 14:16:51 -05:00
end
end
end
end
2013-11-18 12:48:26 -05:00
context 'summary' do
2013-03-22 15:43:57 -04:00
let! ( :p1 ) { Fabricate ( :post , post_args . merge ( score : 4 , percent_rank : 0 . 33 ) ) }
let! ( :p2 ) { Fabricate ( :post , post_args . merge ( score : 10 , percent_rank : 0 . 66 ) ) }
let! ( :p3 ) { Fabricate ( :post , post_args . merge ( score : 5 , percent_rank : 0 . 99 ) ) }
2013-02-05 14:16:51 -05:00
2013-11-18 12:48:26 -05:00
it " returns the OP and posts above the threshold in summary mode " do
SiteSetting . stubs ( :summary_percent_filter ) . returns ( 66 )
2015-01-05 11:04:23 -05:00
expect ( Post . summary . order ( :post_number ) ) . to eq ( [ p1 , p2 ] )
2013-02-05 14:16:51 -05:00
end
end
context 'sort_order' do
context 'regular topic' do
let! ( :p1 ) { Fabricate ( :post , post_args ) }
let! ( :p2 ) { Fabricate ( :post , post_args ) }
let! ( :p3 ) { Fabricate ( :post , post_args ) }
it 'defaults to created order' do
2015-01-05 11:04:23 -05:00
expect ( Post . regular_order ) . to eq ( [ p1 , p2 , p3 ] )
2013-02-05 14:16:51 -05:00
end
end
2013-08-06 17:42:36 -04:00
end
context " reply_history " do
let! ( :p1 ) { Fabricate ( :post , post_args ) }
let! ( :p2 ) { Fabricate ( :post , post_args . merge ( reply_to_post_number : p1 . post_number ) ) }
let! ( :p3 ) { Fabricate ( :post , post_args ) }
let! ( :p4 ) { Fabricate ( :post , post_args . merge ( reply_to_post_number : p2 . post_number ) ) }
it " returns the posts in reply to this post " do
2015-01-05 11:04:23 -05:00
expect ( p4 . reply_history ) . to eq ( [ p1 , p2 ] )
expect ( p4 . reply_history ( 1 ) ) . to eq ( [ p2 ] )
expect ( p3 . reply_history ) . to be_blank
expect ( p2 . reply_history ) . to eq ( [ p1 ] )
2013-08-06 17:42:36 -04:00
end
2013-02-05 14:16:51 -05:00
end
2013-04-22 03:45:03 -04:00
describe 'urls' do
2013-05-10 16:58:23 -04:00
it 'no-ops for empty list' do
2015-01-05 11:04:23 -05:00
expect ( Post . urls ( [ ] ) ) . to eq ( { } )
2013-04-22 03:45:03 -04:00
end
2013-05-10 16:58:23 -04:00
# integration test -> should move to centralized integration test
it 'finds urls for posts presented' do
2013-04-22 03:45:03 -04:00
p1 = Fabricate ( :post )
p2 = Fabricate ( :post )
2015-01-05 11:04:23 -05:00
expect ( Post . urls ( [ p1 . id , p2 . id ] ) ) . to eq ( { p1 . id = > p1 . url , p2 . id = > p2 . url } )
2013-04-22 03:45:03 -04:00
end
end
2013-10-15 10:21:30 -04:00
describe " details " do
it " adds details " do
post = Fabricate . build ( :post )
post . add_detail ( " key " , " value " )
2015-01-05 11:04:23 -05:00
expect ( post . post_details . size ) . to eq ( 1 )
expect ( post . post_details . first . key ) . to eq ( " key " )
expect ( post . post_details . first . value ) . to eq ( " value " )
2013-10-15 10:21:30 -04:00
end
it " can find a post by a detail " do
detail = Fabricate ( :post_detail )
post = detail . post
2015-01-05 11:04:23 -05:00
expect ( Post . find_by_detail ( detail . key , detail . value ) . id ) . to eq ( post . id )
2013-10-15 10:21:30 -04:00
end
end
2014-01-15 11:34:17 -05:00
describe " cooking " do
let ( :post ) { Fabricate . build ( :post , post_args . merge ( raw : " please read my blog http://blog.example.com " ) ) }
it " should add nofollow to links in the post for trust levels below 3 " do
post . user . trust_level = 2
post . save
2015-01-05 11:04:23 -05:00
expect ( post . cooked ) . to match ( / nofollow / )
2014-01-15 11:34:17 -05:00
end
2014-09-04 16:16:46 -04:00
it " when tl3_links_no_follow is false, should not add nofollow for trust level 3 and higher " do
SiteSetting . stubs ( :tl3_links_no_follow ) . returns ( false )
2014-01-15 11:34:17 -05:00
post . user . trust_level = 3
post . save
2015-01-05 11:04:23 -05:00
expect ( post . cooked ) . not_to match ( / nofollow / )
2014-01-15 11:34:17 -05:00
end
2014-07-14 13:34:21 -04:00
2014-09-04 16:16:46 -04:00
it " when tl3_links_no_follow is true, should add nofollow for trust level 3 and higher " do
SiteSetting . stubs ( :tl3_links_no_follow ) . returns ( true )
2014-07-14 13:34:21 -04:00
post . user . trust_level = 3
post . save
2015-01-05 11:04:23 -05:00
expect ( post . cooked ) . to match ( / nofollow / )
2014-07-14 13:34:21 -04:00
end
2014-01-15 11:34:17 -05:00
end
2014-02-26 19:45:20 -05:00
describe " calculate_avg_time " do
it " should not crash " do
Post . calculate_avg_time
Post . calculate_avg_time ( 1 . day . ago )
end
end
2014-02-26 23:43:45 -05:00
describe " has_host_spam " do
it " correctly detects host spam " do
2014-04-28 10:37:28 -04:00
post = Fabricate ( :post , raw : " hello from my site http://www.somesite.com http:// #{ GlobalSetting . hostname } http:// #{ RailsMultisite :: ConnectionManagement . current_hostname } " )
2014-02-26 23:43:45 -05:00
2015-01-05 11:04:23 -05:00
expect ( post . total_hosts_usage ) . to eq ( { " www.somesite.com " = > 1 } )
2014-02-26 23:43:45 -05:00
post . acting_user . trust_level = 0
2015-01-05 11:04:23 -05:00
expect ( post . has_host_spam? ) . to eq ( false )
2014-02-26 23:43:45 -05:00
2014-05-27 22:30:43 -04:00
SiteSetting . newuser_spam_host_threshold = 1
2014-02-26 23:43:45 -05:00
2015-01-05 11:04:23 -05:00
expect ( post . has_host_spam? ) . to eq ( true )
2014-02-26 23:43:45 -05:00
2014-05-27 22:30:43 -04:00
SiteSetting . white_listed_spam_host_domains = " bla.com|boo.com | somesite.com "
2015-01-05 11:04:23 -05:00
expect ( post . has_host_spam? ) . to eq ( false )
2014-02-26 23:43:45 -05:00
end
end
2014-04-25 09:14:05 -04:00
it " has custom fields " do
post = Fabricate ( :post )
2015-01-05 11:04:23 -05:00
expect ( post . custom_fields [ " a " ] ) . to eq ( nil )
2014-04-25 09:14:05 -04:00
post . custom_fields [ " Tommy " ] = " Hanks "
post . custom_fields [ " Vincent " ] = " Vega "
post . save
post = Post . find ( post . id )
2015-01-05 11:04:23 -05:00
expect ( post . custom_fields ) . to eq ( { " Tommy " = > " Hanks " , " Vincent " = > " Vega " } )
2014-04-25 09:14:05 -04:00
end
2014-05-27 22:30:43 -04:00
describe " # rebake! " do
it " will rebake a post correctly " do
post = create_post
2015-01-05 11:04:23 -05:00
expect ( post . baked_at ) . not_to eq ( nil )
2014-05-27 22:30:43 -04:00
first_baked = post . baked_at
first_cooked = post . cooked
Post . exec_sql ( " UPDATE posts SET cooked = 'frogs' WHERE id = ? " , post . id )
post . reload
2014-09-22 12:55:13 -04:00
post . expects ( :publish_change_to_clients! ) . with ( :rebaked )
2014-05-27 22:30:43 -04:00
result = post . rebake!
2015-01-05 11:04:23 -05:00
expect ( post . baked_at ) . not_to eq ( first_baked )
expect ( post . cooked ) . to eq ( first_cooked )
expect ( result ) . to eq ( true )
2014-05-27 22:30:43 -04:00
end
end
describe " .rebake_old " do
it " will catch posts it needs to rebake " do
post = create_post
2014-05-30 00:45:39 -04:00
post . update_columns ( baked_at : Time . new ( 2000 , 1 , 1 ) , baked_version : - 1 )
2014-05-27 22:30:43 -04:00
Post . rebake_old ( 100 )
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . baked_at ) . to be > 1 . day . ago
2014-05-30 00:45:39 -04:00
baked = post . baked_at
Post . rebake_old ( 100 )
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . baked_at ) . to eq ( baked )
2014-05-27 22:30:43 -04:00
end
end
2014-08-11 04:48:00 -04:00
describe " .unhide! " do
before { SiteSetting . stubs ( :unique_posts_mins ) . returns ( 5 ) }
2014-11-12 10:34:30 -05:00
it " will unhide the first post & make the topic visible " do
hidden_topic = Fabricate ( :topic , visible : false )
post = create_post ( topic : hidden_topic )
2014-08-11 04:48:00 -04:00
post . update_columns ( hidden : true , hidden_at : Time . now , hidden_reason_id : 1 )
post . reload
2015-01-05 11:04:23 -05:00
expect ( post . hidden ) . to eq ( true )
2014-08-11 04:48:00 -04:00
2014-09-22 12:55:13 -04:00
post . expects ( :publish_change_to_clients! ) . with ( :acted )
2014-08-11 04:48:00 -04:00
post . unhide!
2014-11-12 10:34:30 -05:00
2014-08-11 04:48:00 -04:00
post . reload
2014-11-12 10:34:30 -05:00
hidden_topic . reload
2014-08-11 04:48:00 -04:00
2015-01-05 11:04:23 -05:00
expect ( post . hidden ) . to eq ( false )
expect ( hidden_topic . visible ) . to eq ( true )
2014-08-11 04:48:00 -04:00
end
end
2014-11-12 10:34:30 -05:00
it " will unhide the post but will keep the topic invisible/unlisted " do
hidden_topic = Fabricate ( :topic , visible : false )
first_post = create_post ( topic : hidden_topic )
second_post = create_post ( topic : hidden_topic )
second_post . update_columns ( hidden : true , hidden_at : Time . now , hidden_reason_id : 1 )
second_post . expects ( :publish_change_to_clients! ) . with ( :acted )
second_post . unhide!
second_post . reload
hidden_topic . reload
2015-01-05 11:04:23 -05:00
expect ( second_post . hidden ) . to eq ( false )
expect ( hidden_topic . visible ) . to eq ( false )
2014-11-12 10:34:30 -05:00
end
2013-02-05 14:16:51 -05:00
end