From f16ec24893689975ef50b30ceda37b6fc47fee57 Mon Sep 17 00:00:00 2001
From: Nick Winter <livelily@gmail.com>
Date: Tue, 10 Feb 2015 13:16:09 -0800
Subject: [PATCH] Fixed a few typos in analytics queries.

---
 scripts/analytics/mongodb/queries/abForeshadowsLevels.js | 2 +-
 scripts/analytics/mongodb/queries/abGemPromptGroup.js    | 2 +-
 scripts/analytics/mongodb/queries/abLeaderboardsGroup.js | 8 ++++++--
 scripts/analytics/mongodb/queries/abShowsPortal.js       | 8 ++------
 scripts/analytics/mongodb/queries/abTestHelpers.js       | 2 +-
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/scripts/analytics/mongodb/queries/abForeshadowsLevels.js b/scripts/analytics/mongodb/queries/abForeshadowsLevels.js
index c7bf4f83b..13f31a273 100644
--- a/scripts/analytics/mongodb/queries/abForeshadowsLevels.js
+++ b/scripts/analytics/mongodb/queries/abForeshadowsLevels.js
@@ -34,7 +34,7 @@ try {
 
   var funnelData = getFunnelData(startDay, eventFunnel, testGroupFn, levelSlugs);
 
-  log("Day\tLevel\tGroup\tStarted\tFinsihed\tCompletion Rate");
+  log("Day\tLevel\tGroup\tStarted\tFinished\tCompletion Rate");
   var overallCounts = {};
   for (var i = 0; i < funnelData.length; i++) {
     var level = funnelData[i].level;
diff --git a/scripts/analytics/mongodb/queries/abGemPromptGroup.js b/scripts/analytics/mongodb/queries/abGemPromptGroup.js
index 7b4295f5c..d77c03fed 100644
--- a/scripts/analytics/mongodb/queries/abGemPromptGroup.js
+++ b/scripts/analytics/mongodb/queries/abGemPromptGroup.js
@@ -33,7 +33,7 @@ try {
 
   var funnelData = getFunnelData(startDay, eventFunnel, testGroupFn);
 
-  log("Day\t\tGroup\t\tStarted\tFinsihed\tCompletion Rate");
+  log("Day\t\tGroup\t\tStarted\tFinished\tCompletion Rate");
   var overallCounts = {};
   for (var i = 0; i < funnelData.length; i++) {
     var day = funnelData[i].day;
diff --git a/scripts/analytics/mongodb/queries/abLeaderboardsGroup.js b/scripts/analytics/mongodb/queries/abLeaderboardsGroup.js
index bdf857ca5..e9bd140a0 100644
--- a/scripts/analytics/mongodb/queries/abLeaderboardsGroup.js
+++ b/scripts/analytics/mongodb/queries/abLeaderboardsGroup.js
@@ -28,12 +28,16 @@ try {
 
   // getLeaderboardsGroup
   var testGroupFn = function (testGroupNumber) {
-    return testGroupNumber < 128;
+    var group = testGroupNumber % 64;
+    if (group < 16) return 'always';
+    if (group < 32) return 'early';
+    if (group < 48) return 'late';
+    return 'never';
   }
 
   var funnelData = getFunnelData(startDay, eventFunnel, testGroupFn, levelSlugs);
 
-  log("Day\tLevel\tGroup\tStarted\tFinsihed\tCompletion Rate");
+  log("Day\tLevel\tGroup\tStarted\tFinished\tCompletion Rate");
   var overallCounts = {};
   for (var i = 0; i < funnelData.length; i++) {
     var level = funnelData[i].level;
diff --git a/scripts/analytics/mongodb/queries/abShowsPortal.js b/scripts/analytics/mongodb/queries/abShowsPortal.js
index 9beee1bb5..27d062d8e 100644
--- a/scripts/analytics/mongodb/queries/abShowsPortal.js
+++ b/scripts/analytics/mongodb/queries/abShowsPortal.js
@@ -28,16 +28,12 @@ try {
 
   // getShowsPortal
   var testGroupFn = function (testGroupNumber) {
-    var group = testGroupNumber % 64
-    if (group < 16) return 'always';
-    if (group < 32) return 'early';
-    if (group < 48) return 'late';
-    return 'never';
+    return testGroupNumber < 128;
   }
 
   var funnelData = getFunnelData(startDay, eventFunnel, testGroupFn, levelSlugs);
 
-  log("Day\tLevel\tGroup\tStarted\tFinsihed\tCompletion Rate");
+  log("Day\tLevel\tGroup\tStarted\tFinished\tCompletion Rate");
   var overallCounts = {};
   for (var i = 0; i < funnelData.length; i++) {
     var level = funnelData[i].level;
diff --git a/scripts/analytics/mongodb/queries/abTestHelpers.js b/scripts/analytics/mongodb/queries/abTestHelpers.js
index 80eaf2931..b90769c1b 100644
--- a/scripts/analytics/mongodb/queries/abTestHelpers.js
+++ b/scripts/analytics/mongodb/queries/abTestHelpers.js
@@ -3,7 +3,7 @@
 // Main API is getFunnelData() which returns per-day funnel completion rates
 
 // TODO: use levelSlugs in query if available
-// TODO: Stop looking up testGroupNumber when test group data is available in analytisc.log.events
+// TODO: Stop looking up testGroupNumber when test group data is available in analytics.log.events
 // TODO: These are super slow, need to aggregate into analytics.perdays collection
 
 var analyticsStringCache = {};