From eadde0590e37c864e882ed8cbf4342daaffd29a2 Mon Sep 17 00:00:00 2001 From: Matt Lott <mattlott@live.com> Date: Mon, 15 Dec 2014 14:05:37 -0800 Subject: [PATCH] Turn off fast hero victory modal A/B test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Didn’t make a difference in level completion, opting for no delay in showing the modal buttons. --- app/models/User.coffee | 11 ----------- app/views/play/level/modal/HeroVictoryModal.coffee | 2 -- 2 files changed, 13 deletions(-) diff --git a/app/models/User.coffee b/app/models/User.coffee index ea4b5c3d0..6beae06b4 100644 --- a/app/models/User.coffee +++ b/app/models/User.coffee @@ -115,17 +115,6 @@ module.exports = class User extends CocoModel application.tracker.identify announcesActionAudioGroup: @announcesActionAudioGroup unless me.isAdmin() @announcesActionAudioGroup - getFastVictoryModalGroup: -> - # A/B Testing no delay showing the signup and continue buttons in hero victory modal - return @fastVictoryModalGroup if @fastVictoryModalGroup - group = me.get('testGroupNumber') % 2 - @fastVictoryModalGroup = switch group - when 0 then 'normal' - when 1 then 'fast' - @fastVictoryModalGroup = 'fast' if me.isAdmin() - application.tracker.identify fastVictoryModalGroup: @fastVictoryModalGroup unless me.isAdmin() - @fastVictoryModalGroup - getGemPromptGroup: -> # A/B Testing whether extra prompt when low gems leads to more gem purchases # TODO: Rename gem purchase event in BuyGemsModal to 'Started gem purchase' after this test is over diff --git a/app/views/play/level/modal/HeroVictoryModal.coffee b/app/views/play/level/modal/HeroVictoryModal.coffee index 88727208c..6a61dc28d 100644 --- a/app/views/play/level/modal/HeroVictoryModal.coffee +++ b/app/views/play/level/modal/HeroVictoryModal.coffee @@ -283,8 +283,6 @@ module.exports = class HeroVictoryModal extends ModalView Backbone.Mediator.publish 'music-player:enter-menu', terrain: @level.get('terrain', true) updateSavingProgressStatus: -> - # A/B Testing no delay showing the signup and continue buttons in hero victory modal - return unless @animationComplete or me.getFastVictoryModalGroup() is 'fast' @$el.find('#saving-progress-label').toggleClass('hide', @readyToContinue) @$el.find('.next-level-button').toggleClass('hide', not @readyToContinue) @$el.find('.sign-up-poke').toggleClass('hide', not @readyToContinue)