codeninjasllc/codecombat
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve travis success rate

Browse source 
96076589

Failures:
1) Recalculate Achievements remove earned achievements
  Message:
    Expected 1 to be 0.
  Stack:
    Error: Expected 1 to be 0.
...

Apparently EarnedAchievement creation from previous tests bleeds into this test case.
Adding a timeout to minimize the race condition problem here.
This commit is contained in:
Scott Erickson 2015-12-18 10:40:37 -08:00
parent 079109145f
commit def3e9a009
1 changed files with 10 additions and 8 deletions

18
spec/server/functional/achievement.spec.coffee
View file

@ -220,14 +220,16 @@ describe 'Recalculate Achievements', ->
EarnedAchievementHandler = require '../../../server/achievements/earned_achievement_handler' EarnedAchievementHandler = require '../../../server/achievements/earned_achievement_handler'
it 'remove earned achievements', (done) -> it 'remove earned achievements', (done) ->
clearModels [EarnedAchievement], (err) -> f = ->
expect(err).toBeNull() clearModels [EarnedAchievement], (err) ->
EarnedAchievement.find {}, (err, earned) -> expect(err).toBeNull()
expect(earned.length).toBe 0 EarnedAchievement.find {}, (err, earned) ->
expect(earned.length).toBe 0
User.update {}, {$set: {points: 0}}, {multi:true}, (err) ->
expect(err).toBeNull() User.update {}, {$set: {points: 0}}, {multi:true}, (err) ->
done() expect(err).toBeNull()
done()
setTimeout f, 100 # wait for previous tests to wrap up to avoid race condition
it 'can not be accessed by regular users', (done) -> it 'can not be accessed by regular users', (done) ->
loginJoe -> request.post {uri:getURL '/admin/earned_achievement/recalculate'}, (err, res, body) -> loginJoe -> request.post {uri:getURL '/admin/earned_achievement/recalculate'}, (err, res, body) ->