codeninjasllc/codecombat
1
0
Fork 0
mirror of https://github.com/codeninjasllc/codecombat.git synced 2025-03-14 07:00:01 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed bugs with forking ThangTypes.

Browse source
This commit is contained in:
Nick Winter 2014-09-08 16:03:29 -07:00
parent c64c391d74
commit dd2cdf3ef9
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/models/CocoModel.coffee
View file

@ -96,7 +96,9 @@ class CocoModel extends Backbone.Model
schema: -> return @constructor.schema
getValidationErrors: ->
errors = tv4.validateMultiple(@attributes, @constructor.schema or {}).errors
# Since Backbone unset only sets things to undefined instead of deleting them, we ignore undefined properties.
definedAttributes = _.pick @attributes, (v) -> v isnt undefined
errors = tv4.validateMultiple(definedAttributes, @constructor.schema or {}).errors
return errors if errors?.length
validate: ->

2
app/views/editor/ForkModal.coffee
View file

@ -31,7 +31,7 @@ module.exports = class ForkModal extends ModalView
newModel.unset 'parent'
newModel.set 'commitMessage', "Forked from #{@model.get('name')}"
newModel.set 'name', @$el.find('#fork-model-name').val()
if @model.schema.properties.permissions
if @model.schema().properties.permissions
newModel.set 'permissions', [access: 'owner', target: me.id]
newPathPrefix = "editor/#{@editorPath}/"
res = newModel.save()

2
app/views/modal/NewModelModal.coffee
View file

@ -28,7 +28,7 @@ module.exports = class NewModelModal extends ModalView
model = new @model
name = @$el.find('#name').val()
model.set('name', name)
if @model.schema.properties.permissions
if @model.schema().properties.permissions
model.set 'permissions', [{access: 'owner', target: me.id}]
model.set(key, prop) for key, prop of @properties if @properties?
model