mirror of
https://github.com/codeninjasllc/codecombat.git
synced 2025-03-14 07:00:01 -04:00
Add hero. autocomplete entries
Adding up to 10 highest importance hero. duplicate autocomplete entries that include ‘hero.’ Increasing max suggestions allowed from 10 to 20
This commit is contained in:
parent
954780d19f
commit
d14bea3110
1 changed files with 11 additions and 2 deletions
|
@ -201,7 +201,7 @@ module.exports = class Zatanna
|
|||
# Hide popup if more than 10 suggestions
|
||||
# TODO: Completions aren't asked for unless we show popup, so this is super hacky
|
||||
# TODO: Backspacing to yield more suggestions does not close popup
|
||||
if editor.completer?.completions?.filtered?.length > 10
|
||||
if editor.completer?.completions?.filtered?.length > 20
|
||||
editor.completer.detach()
|
||||
|
||||
# Update popup CSS after it's been launched
|
||||
|
@ -244,6 +244,7 @@ module.exports = class Zatanna
|
|||
|
||||
addCodeCombatSnippets: (level, spellView, e) ->
|
||||
snippetEntries = []
|
||||
source = spellView.getSource()
|
||||
haveFindNearestEnemy = false
|
||||
haveFindNearest = false
|
||||
for group, props of e.propGroups
|
||||
|
@ -279,7 +280,6 @@ module.exports = class Zatanna
|
|||
else 'while true'
|
||||
# For now, update autocomplete to use hero instead of self/this, if hero is already used in the source.
|
||||
# Later, we should make this happen all the time - or better yet update the snippets.
|
||||
source = spellView.getSource()
|
||||
if /hero/.test(source) or not /(self[\.\:]|this\.|\@)/.test(source)
|
||||
thisToken =
|
||||
'python': /self/,
|
||||
|
@ -318,6 +318,15 @@ module.exports = class Zatanna
|
|||
attackEntry.content = attackEntry.content.replace '${1:enemy}', '"${1:Enemy Name}"'
|
||||
snippetEntries.push attackEntry
|
||||
|
||||
# Add copied hero. entries for most important ones that start with hero.
|
||||
sortedEntries = _.sortBy snippetEntries, (entry) -> -1 * parseInt(entry.importance ? 0)
|
||||
for entry in sortedEntries
|
||||
if entry.content?.indexOf('hero.') is 0
|
||||
newEntry = _.cloneDeep(entry)
|
||||
entry.name = "hero.#{newEntry.name}"
|
||||
snippetEntries.push(newEntry)
|
||||
break if snippetEntries.length - sortedEntries.length >= 10
|
||||
|
||||
if haveFindNearest and not haveFindNearestEnemy
|
||||
spellView.translateFindNearest()
|
||||
|
||||
|
|
Loading…
Reference in a new issue