codeninjasllc/codecombat
1
0
Fork 0
mirror of https://github.com/codeninjasllc/codecombat.git synced 2024-11-27 09:35:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactored LevelLoader's loading of session dependencies a bit so it's easy to have it load them on demand.

Browse source
This commit is contained in:
Scott Erickson 2014-08-15 12:41:29 -07:00
parent 69ab177702
commit 86ba46b64c
2 changed files with 54 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/lib/LevelLoader.coffee
View file

@ -67,16 +67,17 @@ module.exports = class LevelLoader extends CocoClass
session = new LevelSession().setURL url
@sessionResource = @supermodel.loadModel(session, 'level_session', {cache: false})
@session = @sessionResource.model
@listenToOnce @session, 'sync', @onSessionLoaded
@listenToOnce @session, 'sync', ->
@session.url = -> '/db/level.session/' + @id
@loadDependenciesForSession(@session)
if @opponentSessionID
opponentSession = new LevelSession().setURL "/db/level_session/#{@opponentSessionID}"
@opponentSessionResource = @supermodel.loadModel(opponentSession, 'opponent_session')
@opponentSession = @opponentSessionResource.model
@listenToOnce @opponentSession, 'sync', @onSessionLoaded
@listenToOnce @opponentSession, 'sync', @loadDependenciesForSession
onSessionLoaded: (session) ->
session.url = -> '/db/level.session/' + @id
loadDependenciesForSession: (session) ->
if heroConfig = session.get('heroConfig')
url = "/db/thang.type/#{heroConfig.thangType}/version?project=name,components,original"
@worldNecessities.push @maybeLoadURL(url, ThangType, 'thang')

55
test/app/lib/LevelLoader.spec.coffee
View file

@ -41,6 +41,8 @@ levelWithShamanWithSuperWand = {
sessionWithTharinWithHelmet = { heroConfig: { thangType: 'tharin', inventory: { 'head': 'helmet' }}}
sessionWithAnyaWithGloves = { heroConfig: { thangType: 'anya', inventory: { 'head': 'gloves' }}}
# THANG TYPES
thangTypeOgreWithPhysicalComponent = {
@ -80,34 +82,55 @@ thangTypeWand = {
}]
}
thangTypeAnyaWithJumpsComponent = {
name: 'Anya'
original: 'anya'
components: [{
original: 'jumps'
majorVersion: 0
}]
}
describe 'LevelLoader', ->
it 'loads hero and item thang types from heroConfig in the LevelSession', ->
new LevelLoader({supermodel:new SuperModel(), sessionID: 'id', levelID: 'id'})
describe 'loadDependenciesForSession', ->
it 'loads hero and item thang types from heroConfig in the given session', ->
levelLoader = new LevelLoader({supermodel:new SuperModel(), sessionID: 'id', levelID: 'id'})
session = new LevelSession(sessionWithAnyaWithGloves)
levelLoader.loadDependenciesForSession(session)
requests = jasmine.Ajax.requests.all()
urls = (r.url for r in requests)
expect('/db/thang.type/gloves/version?project=name,components,original' in urls).toBeTruthy()
expect('/db/thang.type/anya/version?project=name,components,original' in urls).toBeTruthy()
it 'loads components for the hero in the heroConfig in the given session', ->
levelLoader = new LevelLoader({supermodel:new SuperModel(), sessionID: 'id', levelID: 'id'})
session = new LevelSession(sessionWithAnyaWithGloves)
levelLoader.loadDependenciesForSession(session)
responses = {
'/db/level_session/id': sessionWithTharinWithHelmet
'/db/thang.type/anya/version?project=name,components,original': thangTypeAnyaWithJumpsComponent
}
jasmine.Ajax.requests.sendResponses(responses)
requests = jasmine.Ajax.requests.all()
urls = (r.url for r in requests)
expect('/db/thang.type/helmet/version?project=name,components,original' in urls).toBeTruthy()
expect('/db/thang.type/tharin/version?project=name,components,original' in urls).toBeTruthy()
expect('/db/level.component/jumps/version/0' in urls).toBeTruthy()
it 'loads components for the hero in the heroConfig in the LevelSession', ->
new LevelLoader({supermodel:new SuperModel(), sessionID: 'id', levelID: 'id'})
responses = {
'/db/level_session/id': sessionWithTharinWithHelmet
'/db/thang.type/tharin/version?project=name,components,original': thangTypeTharinWithHealsComponent
}
it 'is idempotent', ->
levelLoader = new LevelLoader({supermodel:new SuperModel(), sessionID: 'id', levelID: 'id'})
# first load Tharin by the 'normal' session load
responses = { '/db/level_session/id': sessionWithTharinWithHelmet }
jasmine.Ajax.requests.sendResponses(responses)
requests = jasmine.Ajax.requests.all()
urls = (r.url for r in requests)
expect('/db/level.component/heals/version/0' in urls).toBeTruthy()
numRequestsBefore = jasmine.Ajax.requests.count()
# then try to load Tharin some more
session = new LevelSession(sessionWithTharinWithHelmet)
levelLoader.loadDependenciesForSession(session)
levelLoader.loadDependenciesForSession(session)
levelLoader.loadDependenciesForSession(session)
numRequestsAfter = jasmine.Ajax.requests.count()
expect(numRequestsBefore).toBe(numRequestsAfter)
it 'loads thangs for items that the level thangs have in their Equips component configs', ->
new LevelLoader({supermodel:supermodel = new SuperModel(), sessionID: 'id', levelID: 'id'})