codeninjasllc/codecombat
1
0
Fork 0
mirror of https://github.com/codeninjasllc/codecombat.git synced 2024-11-28 01:55:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Turned off DOM highlight noise after A/B test insignificantly showed it hurting.

Browse source
This commit is contained in:
Nick Winter 2014-11-18 08:05:20 -08:00
parent d0233fc999
commit 547ba692e1
2 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
app/models/User.coffee
View file

@ -143,15 +143,18 @@ module.exports = class User extends CocoModel
application.tracker.identify experimentalLangGroup: @experimentalLangGroup
@experimentalLangGroup
getHighlightArrowSoundGroup: ->
return @highlightArrowGroup if @highlightArrowGroup
group = me.get('testGroupNumber') % 8
@highlightArrowGroup = switch group
when 0, 1, 2, 3 then 'sound-off'
when 4, 5, 6, 7 then 'sound-on'
@highlightArrowGroup = 'sound-off' if me.isAdmin()
application.tracker.identify highlightArrowGroup: @highlightArrowGroup unless me.isAdmin()
@highlightArrowGroup
## Test complete; feel free to repurpose for another test.
# https://mixpanel.com/report/227350/segmentation/#action:segment,arb_event:'Saw%20Victory',bool_op:and,chart_type:bar,from_date:-17,segfilter:!((filter:(operand:!('Dungeons%20of%20Kithgard'),operator:%3D%3D),property:level,selected_property_type:string,type:string),(filter:(operand:'',operator:set),property:highlightArrowGroup,selected_property_type:string,type:string),(property:highlightArrowGroup,selected_property_type:string,type:string)),segment_type:string,to_date:0,type:unique,unit:day
# https://www.dropbox.com/s/jot1ikz7nk7jti5/Screenshot%202014-11-18%2008.04.00.png?dl=0
#getHighlightArrowSoundGroup: ->
# return @highlightArrowGroup if @highlightArrowGroup
# group = me.get('testGroupNumber') % 8
# @highlightArrowGroup = switch group
# when 0, 1, 2, 3 then 'sound-off'
# when 4, 5, 6, 7 then 'sound-on'
# @highlightArrowGroup = 'sound-off' if me.isAdmin()
# application.tracker.identify highlightArrowGroup: @highlightArrowGroup unless me.isAdmin()
# @highlightArrowGroup
getKithmazeGroup: ->
return @kithmazeGroup if @kithmazeGroup

4
app/views/kinds/CocoView.coffee
View file

@ -99,7 +99,7 @@ module.exports = class CocoView extends Backbone.View
@$el.find(selector).replaceWith(newTemplate.find(selector))
@delegateEvents()
@$el.i18n()
render: ->
return @ unless me
view.destroy() for id, view of @subviews
@ -358,8 +358,6 @@ module.exports = class CocoView extends Backbone.View
animatePointer: =>
$pointer = @getPointer()
$pointer.css transition: 'all 0.6s ease-out', transform: "rotate(#{@pointerRotation}rad) translate(-3px, #{@pointerRadialDistance-50}px)"
if me.getHighlightArrowSoundGroup() is 'sound-on'
Backbone.Mediator.publish 'audio-player:play-sound', trigger: 'dom_highlight', volume: 0.5
setTimeout (=> $pointer.css transition: 'all 0.4s ease-in', transform: "rotate(#{@pointerRotation}rad) translate(-3px, #{@pointerRadialDistance}px)"), 800
endHighlight: ->