Refactored and added sample objects/errors

server/commons/errors.coffee

@@ -33,3 +33,7 @@ module.exports.badInput = (res, message='Unprocessable Entity. Bad Input.') ->
 module.exports.serverError = (res, message='Internal Server Error') ->
   res.send 500, message
   res.end()
+
+module.exports.gatewayTimeoutError = (res, message="Gateway timeout") ->
+  res.send 504, message
+  res.end()

server/queues/scoring.coffee

@@ -6,58 +6,52 @@ errors = require '../commons/errors'
 aws = require 'aws-sdk'
 db = require './../routes/db'
 mongoose = require 'mongoose'
-events = require 'events'
 queues = require '../commons/queue'
 LevelSession = require '../levels/sessions/LevelSession'
 
 scoringTaskQueue = undefined
+scoringTaskTimeoutInSeconds = 20
 
 connectToScoringQueue = ->
   queues.initializeQueueClient ->
     queues.queueClient.registerQueue "scoring", {}, (err,data) ->
-      if err?
-        winston.error "There was an error registering the scoring queue."
-        throw new Error  "There was an error registering the scoring queue."
+      throwScoringQueueRegistrationError(err) if err?
       scoringTaskQueue = data
-      winston.info "Connected to scoring task queue!"  unless err?
+      winston.info "Connected to scoring task queue!"
+
+throwScoringQueueRegistrationError = (error) ->
+  winston.error "There was an error registering the scoring queue: #{error}"
+  throw new Error  "There was an error registering the scoring queue."
+
+
+module.exports.setup = (app) -> connectToScoringQueue()
 
-module.exports.setup = (app) ->
-  connectToScoringQueue()
 
 module.exports.dispatchTaskToConsumer = (req, res) ->
   scoringTaskQueue.receiveMessage (err, message) ->
-    ###Using Test Message
-    { "sessionID": "52dfeb17c8b5f435c7000025" }
-    ###
-    if message.isEmpty()
-      #TODO: Set message code as 504 Gateway Timeout
-      sendResponseObject req, res, {"error":"No messages were received."}
-    else
-      try
-        messageBody = JSON.parse message.getBody()
-      catch
-        return sendResponseObject req, res, {"error":"There was an error parsing the task."}
-      constructTaskObject messageBody, (taskConstructionError, taskObject) ->
-        if taskConstructionError?
-          sendResponseObject req, res, {"error":taskConstructionError}
-        else
-          sendResponseObject req, res, taskObject
+    return errors.gatewayTimeoutError res, "No messages were receieved from the queue" if message.isEmpty()
+
+    messageBody = parseTaskQueueMessage req, res, message
+    return errors.serverError res, "There was an error parsing the queue message" unless messageBody?
+
+    constructTaskObject messageBody, (taskConstructionError, taskObject) ->
+      return errors.serverError res, "There was an error constructing the scoring task" if taskConstructionError?
+      message.changeMessageVisibilityTimeout scoringTaskTimeoutInSeconds
+      sendResponseObject req, res, taskObject
 
 
-module.exports.processTaskResult = (req, res) ->
-  #clientResponseObject = JSON.parse req.body
-  res.end("You posted an object to score!")
-
-
-sendResponseObject = (req,res,object) ->
-  res.setHeader('Content-Type', 'application/json')
-  res.send(object)
-  res.end()
+parseTaskQueueMessage = (req, res, message) ->
+  try
+    return messageBody = JSON.parse message.getBody()
+  catch e
+    sendResponseObject req, res, {"error":"There was an error parsing the task."}
+    null
 
 
 constructTaskObject = (taskMessageBody, callback) ->
   getSessionInformation taskMessageBody.sessionID, (err, sessionInformation) ->
     return callback err, data if err?
+
     taskObject =
       "messageGenerated": Date.now()
       "sessionID": sessionInformation.sessionID
@@ -67,31 +61,97 @@ constructTaskObject = (taskMessageBody, callback) ->
       "players": sessionInformation.players
 
     callback err, taskObject
-    ###
-    "players" : [
-      {"ID":"51eb2714fa058cb20d0006ef", "team":"humans", "userCodeMap": "code goes here"}
-      {"ID":"51eb2714fa058cb20d00fedg", "team":"ogres","userCodeMap": "code goes here"}
-    ]
-    ###
-
 
 
 getSessionInformation = (sessionIDString, callback) ->
   LevelSession.findOne {"_id": sessionIDString }, (err, session) ->
-    if err?
-      callback err, {"error":"There was an error retrieving the session."}
-    else
-      session = session.toJSON()
-      sessionInformation =
-        "sessionID": session._id
-        "players": _.cloneDeep session.players
-        "code": _.cloneDeep session.code
-        "changed": session.changed
-        "creator": session.creator
-      callback err, sessionInformation
+    return callback err, {"error":"There was an error retrieving the session."} if err?
 
-processClientResponse = (clientResponseBody, callback) ->
-  return
+    session = session.toJSON()
+    sessionInformation =
+      "sessionID": session._id
+      "players": _.cloneDeep session.players
+      "code": _.cloneDeep session.code
+      "changed": session.changed
+      "creator": session.creator
+
+    callback err, sessionInformation
+
+
+sendResponseObject = (req,res,object) ->
+  res.setHeader('Content-Type', 'application/json')
+  res.send(object)
+  res.end()
+
+module.exports.processTaskResult = (req, res) ->
+  #clientResponseObject = JSON.parse req.body
+  #check for timeout
+
+  res.end("You posted an object to score!")
 
 
 
+###Sample Messages
+sampleQueueMessage =
+  sessions: [
+    "52dfeb17c8b5f435c7000025"
+  ]
+
+sampleUndoneTaskObject =
+  "taskID": "507f191e810c19729de860ea"
+  "sessions" : [
+    {
+      "ID":"52dfeb17c8b5f435c7000025"
+      "sessionChangedTime": "2014-01-22T16:28:12.450Z"
+      "team":"humans"
+      "code": "code goes here"
+    },
+    {
+      "ID":"51eb2714fa058cb20d00fedg"
+      "sessionChangedTime": "2014-01-22T16:28:12.450Z"
+      "team":"ogres"
+      "code": "code goes here"
+    }
+  ]
+sampleResponseObject =
+  "taskID": "507f191e810c19729de860ea"
+  "calculationTime":3201
+  "sessions": [
+    {
+      "ID":"52dfeb17c8b5f435c7000025"
+      "sessionChangedTime": "2014-01-22T16:28:12.450Z"
+      "metrics": {
+        "rank":2
+      }
+    },
+    {
+      "ID":"51eb2714fa058cb20d00fedg"
+      "sessionChangedTime": "2014-01-22T16:28:12.450Z"
+      "metrics": {
+        "rank":1
+      }
+    }
+  ]
+
+sampleTaskLogObject=
+{
+  "_id":ObjectId("507f191e810c19729de860ea") #datestamp is built into objectId
+  "calculatedBy":ObjectId("51eb2714fa058cb20d0006ef")
+  "calculationTime":3201
+  "sessions":[
+    {
+      "ID":ObjectId("52dfeb17c8b5f435c7000025")
+      "metrics": {
+        "rank":2
+      }
+    },
+    {
+      "ID":ObjectId("51eb2714fa058cb20d00feda")
+      "metrics": {
+        "rank":1
+      }
+    }
+  ]
+}
+
+###