codeninjasllc/codecombat
1
0
Fork 0
mirror of https://github.com/codeninjasllc/codecombat.git synced 2024-11-24 08:08:15 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Handling another error noted with Errorception. Updated minimum Firefox version to 25 based on seeing many (possibly non-critical) errors with it.

Browse source
This commit is contained in:
Nick Winter 2014-12-06 12:02:48 -08:00
parent 708f0e543c
commit 491a7ef456
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/HomeView.coffee
View file

@ -22,9 +22,9 @@ module.exports = class HomeView extends RootView
c = super()
if $.browser
majorVersion = $.browser.versionNumber
c.isOldBrowser = true if $.browser.mozilla && majorVersion < 21
c.isOldBrowser = true if $.browser.mozilla && majorVersion < 25
c.isOldBrowser = true if $.browser.chrome && majorVersion < 25
c.isOldBrowser = true if $.browser.safari && majorVersion < 6
c.isOldBrowser = true if $.browser.safari && majorVersion < 6 # 6 might have problems with Aether, or maybe just old minors of 6: https://errorception.com/projects/51a79585ee207206390002a2/errors/547a202e1ead63ba4e4ac9fd
else
console.warn 'no more jquery browser version...'
c.isEnglish = (me.get('preferredLanguage') or 'en').startsWith 'en'

1
app/views/play/modal/PlayItemsModal.coffee
View file

@ -152,6 +152,7 @@ module.exports = class PlayItemsModal extends ModalView
onScrollItemPane: ->
# dynamically load visible items when the user scrolls enough to see them
return console.error "Couldn't update scroll, since paneNanoContent wasn't initialized." unless @paneNanoContent
items = @paneNanoContent.find('.item:not(.loaded)')
threshold = @paneNanoContent.height() + 100
for itemEl in items