codeninjasllc/codecombat
1
0
Fork 0
mirror of https://github.com/codeninjasllc/codecombat.git synced 2024-11-27 17:45:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove iframe borders using CSS instead of DOM

Browse source 
This patch makes iframe borders render identically in all supported browsers (i.e. no border).

Although Chrome does not displays borders around iframes by default, Firefox and Edge (IE) had visible iframe borders prior to this patch. This is because, as [previously mentioned](https://github.com/codecombat/codecombat/pull/3122#discussion_r42338590), the DOM property was mistyped as `frameborder` when it should be `frameBorder`.

As this is presentational issue, it feels more appropriate to fix it using CSS. Therefore, I've removed the buggy JS code and added a generic CSS solution to reset iframes' border styling.
This commit is contained in:
UltCombo 2015-10-19 22:58:51 -02:00
parent 2539814687
commit 2c97238a7f
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/styles/common/common.sass
View file

@ -14,6 +14,9 @@ h1, h2, h3, h4, h5, h6
a
cursor: pointer
iframe
border: none
.error
left: 8px

1
app/views/play/menu/GuideView.coffee
View file

@ -121,7 +121,6 @@ module.exports = class LevelGuideView extends CocoView
tag.src = helpVideoURL + "?api=1&badge=0&byline=0&portrait=0&title=0"
tag.height = @helpVideoHeight
tag.width = @helpVideoWidth
tag.frameborder = '0'
tag.allowFullscreen = true
@$el.find('#help-video-player').replaceWith(tag)