Optimize code for Many Scripts

mtkclient/Library/Connection/usblib.py

@@ -95,7 +95,8 @@ class CDC_CMDS:
 
 class usb_class(DeviceClass):
 
-    def load_windows_dll(self):
+    @staticmethod
+    def load_windows_dll():
         if os.name == 'nt':
             windows_dir = None
             try:

mtkclient/Library/DA/mtk_da_handler.py

@@ -30,7 +30,8 @@ class DA_handler(metaclass=LogBase):
         self.eh = ErrorHandler()
         self.mtk = mtk
 
-    def close(self):
+    @staticmethod
+    def close():
         sys.exit(0)
 
     def dump_preloader_ram(self):

mtkclient/Library/DA/xflash/xflash_lib.py

@@ -72,7 +72,8 @@ class DAXFlash(metaclass=LogBase):
         except Exception:
             self.carbonara = None
 
-    def usleep(self, usec):
+    @staticmethod
+    def usleep(usec):
         time.sleep(usec / 100000)
 
     def ack(self, rstatus=True):

mtkclient/Library/DA/xml/xml_cmd.py

@@ -324,11 +324,13 @@ class XMLCmd(metaclass=LogBase):
         cmd = self.create_cmd("WRITE-REGISTER", content)
         return cmd
 
-    def cmd_read_partition_name(self):
+    @staticmethod
+    def cmd_read_partition_name():
         cmd = ""
         return cmd
 
-    def cmd_debug_ufs(self):
+    @staticmethod
+    def cmd_debug_ufs():
         cmd = ""
         return cmd
 

mtkclient/Library/Hardware/hwcrypto_dxcc.py

@@ -1050,7 +1050,8 @@ class dxcc(metaclass=LogBase):
     def sasi_paldmaunmap(self, value1):
         return
 
-    def sasi_paldmamap(self, value1):
+    @staticmethod
+    def sasi_paldmamap(value1):
         # value2=value1
         return value1
 
@@ -1305,12 +1306,14 @@ class dxcc(metaclass=LogBase):
             self.sasi_sb_adddescsequence(xdesc)
         return self.SB_HalWaitDescCompletion() == 0
 
-    def mtee_decrypt(self, data):
+    @staticmethod
+    def mtee_decrypt(data):
         key = bytes.fromhex("B936C14D95A99585073E5607784A51F7444B60D6BFD6110F76D004CCB7E1950E")
         skey = hashlib.sha256(key).digest()
         return AES.new(key=skey[:16], iv=skey[16:], mode=AES.MODE_CBC).decrypt(data)
 
-    def descramble(self, data):
+    @staticmethod
+    def descramble(data):
         key = bytes.fromhex("5C0E349A27DC46034C7B6744A378BD17")
         iv = bytes.fromhex("A0B0924686447109F2D51DCDDC93458A")
         ctr = Counter.new(128, initial_value=bytes_to_long(iv))

mtkclient/Library/Hardware/hwcrypto_gcpu.py

@@ -675,7 +675,8 @@ class GCpu(metaclass=LogBase):
         self.info("seed: " + hexlify(seed[:16]).decode('utf-8'))
         return self.mtk_crypto_hmac_sha256_by_devkey_using_seed(seed, data)
 
-    def byteswap(self, data):
+    @staticmethod
+    def byteswap(data):
         data = bytearray(data)
         for i in range(0, len(data) // 2):
             j = len(data) - i - 1

mtkclient/Library/Hardware/hwcrypto_sej.py

@@ -184,7 +184,8 @@ class sej(metaclass=LogBase):
         else:
             self.__logger.setLevel(logging.INFO)
 
-    def uffs(self, x):
+    @staticmethod
+    def uffs(x):
         v1 = x
         if x & 0xFFFF:
             result = 1
@@ -669,7 +670,8 @@ class sej(metaclass=LogBase):
         hw_key = self.sej_do_aes(True, iv, swkey, 32)
         self.sej_set_key(AES_HW_WRAP_KEY, AES_KEY_256, hw_key)
 
-    def sej_sec_cfg_sw(self, data, encrypt=True):
+    @staticmethod
+    def sej_sec_cfg_sw(data, encrypt=True):
         """
         Left for reference - hw implementation
         --------------------------------------

mtkclient/Library/mtk_main.py

@@ -166,7 +166,8 @@ class Main(metaclass=LogBase):
         if not os.path.exists("logs"):
             os.mkdir("logs")
 
-    def close(self):
+    @staticmethod
+    def close():
         sys.exit(0)
 
     def cmd_stage(self, mtk, filename, stage2addr, stage2file, verifystage2):

mtkclient/Library/mtk_preloader.py

@@ -1311,7 +1311,8 @@ class Preloader(metaclass=LogBase):
                 self.config.is_brom = False
         return b""
 
-    def prepare_data(self, data, sigdata=b"", maxsize=0):
+    @staticmethod
+    def prepare_data(data, sigdata=b"", maxsize=0):
         gen_chksum = 0
         data = (data[:maxsize] + sigdata)
         if len(data + sigdata) % 2 != 0:

mtkclient/gui/main_gui.py

@@ -314,13 +314,13 @@ class Ui_MainWindow(object):
         self.gridLayout_2 = QGridLayout(self.keytab)
         self.gridLayout_2.setObjectName(u"gridLayout_2")
         self.keytable = QTableWidget(self.keytab)
-        if (self.keytable.columnCount() < 2):
+        if self.keytable.columnCount() < 2:
             self.keytable.setColumnCount(2)
         __qtablewidgetitem = QTableWidgetItem()
         self.keytable.setHorizontalHeaderItem(0, __qtablewidgetitem)
         __qtablewidgetitem1 = QTableWidgetItem()
         self.keytable.setHorizontalHeaderItem(1, __qtablewidgetitem1)
-        if (self.keytable.rowCount() < 7):
+        if self.keytable.rowCount() < 7:
             self.keytable.setRowCount(7)
         __qtablewidgetitem2 = QTableWidgetItem()
         self.keytable.setVerticalHeaderItem(0, __qtablewidgetitem2)

mtkclient/gui/toolkit.py

@@ -10,7 +10,8 @@ from mtkclient.config.payloads import pathconfig
 
 
 class TimeEstim:
-    def calcProcessTime(self, starttime, cur_iter, max_iter):
+    @staticmethod
+    def calcProcessTime(starttime, cur_iter, max_iter):
         telapsed = time.time() - starttime
         if telapsed > 0 and cur_iter > 0:
             testimated = (telapsed / cur_iter) * max_iter