Also removed is the helper deprecatedHookHack() method.
SkinAfterContentHook should be used instead.
Bug: T259400
Change-Id: I3818cf1ea26444f3736af2b48aabf8b67815008a
Having module definitions living inside SkinMonobook makes them
less discoverable. It also shouldn't be necessary - even if there
are soft dependencies on other modules.
A new file resources/optional-enhancements.js is added which will
load the two optional dependencies based on whether they have been
installed on the client.
Bug: T203023
Change-Id: If9a88db52deb0cc91d58cbb40693d4cd448eabbc
I6e69b482cdbc adds a viewport with the same value as MonoBook.
Bug: T258290
Depends-On: I6e69b482cdbc49c09adc6f7cee54f5e17b7c92c4
Change-Id: Iae529da5dba07a2eee91a1fa7b29e4bdc163aa40
The search form no longer changes based on this config variable.
Note that the variable has always been true since its introduction and
there's no way for users to turn it off, so probably the single button
search form has never been shown.
Bug: T256568
Change-Id: I86fde4f89cff553966614d725bbd6ba14d4ab1a4
Per discussion on T254546 the language portal is so long in most
articles that it pushes down other boxes rendering them inaccessible
for this reason make sure Monobook outputs it last.
Bug: T254546
Change-Id: Ib80fa6414e220fbc3c1b6e3527c32fb28b994376
Various extensions reveal the language portal when empty by appending
a link. Monobook needs to check this now itself, to avoid these links
disappearing - for example the Wikidata edit link.
Bug: T252841
Change-Id: If2cf64f6b7ba313d3e437e9da63afa886fee5d11
Currently one has to click save on "Special:Preferences" to reveal
the monobook responsive design option. As of
Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377 we can reveal this conditionally
when the Monobook skin is selected.
Depends-On: Idd06bcfe7935e16732a6a95c1253dbf95c8aca2e
Bug: T246296
Change-Id: Ibd74cc03f3ccbdc0042163c18ab0f71b6aa556f6
Since MonoBook is never cached on Wikimedia wikis, we don't need
to do anything about both modules being loaded in cached HTML.
There should be no differences before and after this change.
The change must apply to skins.monobook.styles and skins.monobook.responsive
as these modules never load at the same time (see setupSkinUserCss).
Bug: T242177
Change-Id: I5e69cd7f37f7b7a2b6325177b6688a426d92d57f
That way hook subscribers can use RequestContext and whatnot instead of having to resort to globals.
Change-Id: I1e4be7156aaea12fef75169bd0216140b9d50388
Add `@param-taint $contents escapes_htmlnoent` annotation to
MonoBookTemplate::getBox(). The method will escape the $contents
parameter if it's an array, but it will not if it's a string; Phan
can't distinguish the types, and assumes it always escapes. Use
escapes_htmlnoent to suppress warnings about double-escaped output.
Change-Id: Id8ef73f2efbe8d4d5510917d55dbac4e41b2b3a1
Directly use the UTF-8 encoding of the 'NO-BREAK SPACE' (U+00A0)
instead of the HTML/XML entitiy  .
Bug: T154300
Change-Id: I610c8c6a70c7561c46f80e40614f69ccedab5194
MonoBookTemplate incorrectly calls getIfExists() for newtalk/undelete:
attributes of wrapper <div> must be under the 'parameters' key.
Change-Id: I5392477d493174b0b5598927bfbcec2029b0987e
Should avoid more of the issues with unwanted appearance of mobile
layouts. Cutoff results in layout switch when sidebar becomes ~a
third of the total window width.
bug: T196213
Change-Id: I9b8baee5fe53316128f864e732c86750b4e5470e
This provides a device agnostic, persistent opt-out for the new responsive
functionality.
The preference will show up under the skin selector if the user has their
skin already set to MonoBook. I considered adding a new skin option to
the radio selector of skins, but that is probably unnecessary for the
majority of users, in addition to complicating how to differentiate the
two modes (Classic MonoBook vs. Modern MonoBook?).
Wikis that want to make this opt-in can control the default in the standard
way ($wgDefaultUserOptions), or hide it entirely ($wgHiddenPrefs).
Change-Id: Id22f8e5199ff2b15fd03c94097db5cdc7188f8b1
* Improve their accessibility by giving both links a full label
("Jump to x" and "Jump to y" instead of "Jump to: ", "x", "y").
This also makes things better for localisation.
* Use pure CSS for the toggling of the visibility on focus,
instead of relying on JavaScript. Especially given the
JS came from core's 'jquery.mw-jump' module, which is
considered technical debt per T195256.
* Use plain <a> links in the HTML instead of wrapped in a <div>.
This solves the long-standing problem whereby the margin
between #contentSub and #mw-content-text had to be awkwardly
negated and overridden.
Bug: T195256
Change-Id: I40a769ee3a822a5a9167ec1d144e6b151eb8e141
* Reorder ULS and Echo links
* Rename conditional module load hook to be more generic, and add
ULS module
* Remove .active bolding from dropdown
Change-Id: I7e746e7c5af8ffd7c4ca06742ab1fe6bc94ba531
Have echo just show the numbers instead of the badges, and add a
text link to special:notifications in the dropdown, as opposed to
entirely reimplementing the flyout layout
Change-Id: I072dbc2b7bf70b6675469e09e3beb3927e06d0f7
Dropdown menus and js interactiveness for people who like to pretend
we live in a modern era or something.
Does not actually support newfangled tapping and swiping stuff.
Does not properly support echo. (will follow up)
Change-Id: I27d50c320b1526b9d158016a0e8022567f78ccc1
* Add screen-mobile.css with basic mobile styles
* Force loading of screen-desktop on IE8- due to lack of
@media width support
* Add some new divs and a set of spoof cactions for jumping
around the page (what's js?)
* Replace cactions label with a more descriptive string (was
previously set to display:none regardless)
* Also add a set of icons for fixed widths for tabs and things
(icons-source.svg is the source file for the set, and includes
a few others that ultimately weren't used here)
Cutoff 850px. Desktop styles should remain unchanged, with
mobile remaining stylistically consistent.
Change-Id: I737a7447db1e44e0d6abaa4c07813295a5ac73a6
More helper functions, general refactoring.
Output structure is all the same, all existing attributes
maintained. Some new ones are added:
* p-personal now rendered via getPortlet; has extra attribs
according to all others rendered with it
* footer rendered with slight variant of getFooter out of
BaseTemplate; has extra language attribs according to that
Change-Id: I462d1222b0166956d3dce17fbceccf386e179e8d
instead of just spitting it out directly
Also rename all of said functions accordingly, add documentation,
and start trying to make an actually cross-compatible version of
getPortlet() for BaseTemplate...
Output should be structurally the same. All existing attributes for
output elements are maintained; some may have new attribs added due
to more consistent render method (getPortlet). (Essentially, if one
item had it, now they all have it.)
New attribs include:
* id
* lang
* dir
* aria-labelledby
Change-Id: I0a7ca1b95c2ad03273ed9c713be0da694c94a176
Also delete unused images, since even if something is
somewhere using them anyway (looked, couldn't find
anything), it wouldn't be able to find them in the new
image location regardless.
Wiki.png, magnify, and link are all part of core and have
been for some time.
Change-Id: Id7a02155a5f1b207908c9c0c8f7519b6d3f9a886
