Commit graph

515 commits

Author SHA1 Message Date
Isarra
a2d4476d12 Style RelatedArticle cards
If RelatedArtcles uses the SkinAfterContent hook (depends-on patch)
and we move the hook out of the main content block (parent patch),
it needs some styles to remain consistent.

Bug: T181242
Change-Id: I9fc00c22fb5e5b7d363455abe9d85062e67c7dfa
Depends-On: Iebd759c0d1a536768d18953f372664df762d9e04
2019-07-26 19:50:24 +00:00
jenkins-bot
6a32ca83c0 Merge "Enhance the 'MonoBookAfterToolbox' hook by passing the class instance to the hook subscribers" 2019-07-21 18:11:17 +00:00
Jack Phoenix
9ade7fcbe6 Enhance the 'MonoBookAfterToolbox' hook by passing the class instance to the hook subscribers
That way hook subscribers can use RequestContext and whatnot instead of having to resort to globals.

Change-Id: I1e4be7156aaea12fef75169bd0216140b9d50388
2019-07-21 18:03:37 +00:00
Translation updater bot
b162339a4a Localisation updates from https://translatewiki.net.
Change-Id: I8dd5724cd88c82af9e94970ece46d18efab00b94
2019-07-17 22:22:56 +02:00
Bartosz Dziewoński
6c53b601f8 Use media queries rather than manual checks for mobile hacks
If the page was long enough to have a vertical scrollbar, the check
for `$( window ).width()` would be incorrect because of the width of
the scrollbar itself. The correct value is `$( window ).outerWidth()`.

But rather than deal with that, we can instead use the API
specifically for matching media queries [1], then copy-paste the
media query from CSS and not have to think about it at all!

[1] https://developer.mozilla.org/en-US/docs/Web/API/Window/matchMedia

Bug: T227916
Change-Id: I79478040620391f5391b10aee52134fde0b88adf
2019-07-12 21:59:26 +02:00
Bartosz Dziewoński
3f52a1796c Fix funny Echo integration when mobile hack kicks in after using the icons
When the icons are clicked for the first time, they are replaced with
a JS interface by Echo code, so don't cache them in a long-lived variable.

Otherwise if the user clicks one of the notification icons, then
resizes the browser to a mobile width, and then resizes it back, we
would insert duplicate Echo icons.

Also rename the temporary variable per conventions.

Bug: T227916
Change-Id: I08f2e3d2e293d727ac4492d1fb6fe2c7c65df4ad
2019-07-12 21:57:12 +02:00
Bartosz Dziewoński
4c4efadf59 When the personal bar doesn't fit, make overflowing links usable
When the personal menu bar is wider than the screen (browser window),
it gets cut off on the left (and the overflowing links slide under the
logo and then off the screen, making it impossible to click them).
This is caused by the `float: right` rule added in 5a7e620. To avoid
this, add `max-width: 100%`, which results in the menu being cut off
on the right again (which lets the user view the overflowing links by
horizontal scrolling).

Bug: T226875
Change-Id: Id4186215cc069f283f8ebeca0db587e1f1369062
2019-07-12 21:30:21 +02:00
MarcoAurelio
664fbbfce9 build: Updated composer dependencies
Change-Id: Ia95b81e3f5639324cd5ee1d038b77be75d49d28c
2019-07-12 15:47:07 +00:00
MarcoAurelio
f4a17ce80e build: Update npm dependencies
eslint-config-wikimedia  0.11.0  →  0.13.1
 grunt-banana-checker      0.7.0  →   0.7.1
 grunt-eslint             21.0.0  →  22.0.0
 grunt-jsonlint            1.1.0  →   2.0.0
 grunt-stylelint          0.10.1  →  0.11.0
 grunt-svgmin              5.0.0  →   6.0.0

Updates also package-lock.json

Change-Id: Iadda9f7b15f5c70819c7b9599af754d9dd1b641b
2019-07-11 22:50:29 +00:00
James D. Forrester
147550142d build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
Add `@param-taint $contents escapes_htmlnoent` annotation to
MonoBookTemplate::getBox(). The method will escape the $contents
parameter if it's an array, but it will not if it's a string; Phan
can't distinguish the types, and assumes it always escapes. Use
escapes_htmlnoent to suppress warnings about double-escaped output.

Change-Id: Id8ef73f2efbe8d4d5510917d55dbac4e41b2b3a1
2019-07-10 17:12:44 +02:00
jenkins-bot
fa1deee55e Merge "Move DataAfterContent outside of main content block" 2019-07-08 21:18:35 +00:00
Isarra
5a7e620ed5 Echo compatibility: use float: right instead of text-align: right
on personal tools

Echo badges, like all OOUI buttons and quite a few other elements,
hide their labels with a negative text indent. This does not work
properly with backwards text alignment (align: right in ltr
scripts). We can achieve the same visual effect as the text-align:
right on the personal tools, however, by floating the entire list
right instead, thus unbreaking the default badge label hiding
method and also rendering the skin more consistent with Vector,
Example, etc.

And this should negate the need for bonkers workarounds.

Bug: T226684
Bug: T226594
Change-Id: I0ed21a78feb1b1298c30b969a1c80a4323e74043
2019-06-28 02:18:17 +00:00
MarcoAurelio
dd06d6e216 Use oojs-ui.styles.icons-alerts
`ext.echo.badgeicons` got removed in was removed in I8218530e.

Bug: T226503
Change-Id: Id4d912fdaedf94dca8c42d64cc1f342f5566e642
2019-06-25 14:29:29 +00:00
Translation updater bot
8cc92e6289 Localisation updates from https://translatewiki.net.
Change-Id: Iebcecca0c02f0c5de619e7ac83f2c3bd4256f1ad
2019-06-23 22:11:21 +02:00
Timo Tijhof
896f88e740 Use array_merge() instead of manual assignment loop
Change-Id: I0acd669658720ec95e724fd91ef41060560b4888
2019-06-20 19:22:42 +00:00
Isarra
c86558a8b4 I have no damn clue!
Change-Id: Icf173be114856897c0663b04c1a4e19aada0e74b
2019-06-20 19:06:08 +00:00
Isarra
1e0aa01470 Move DataAfterContent outside of main content block
Bug: T226199
Change-Id: I367302e528a4df7c4b53c93caa5b4ba2bfd30e33
2019-06-20 17:43:25 +00:00
MarcoAurelio
d9a330bbae build: Update some composer dependencies
Change-Id: Ib12ae38630698830c1f45f15f3bc49a0204c5f76
2019-06-16 11:13:28 +00:00
libraryupgrader
d79dc21f3c build: Updating mediawiki/mediawiki-phan-config to 0.6.1
Change-Id: Iad6356522cfc4d1980005364d5e5ae919fdc3477
2019-06-10 04:40:15 +00:00
libraryupgrader
106030367e build: Updating npm dependencies for security issues
* Updated grunt to 1.0.4, addressing:
  * https://npmjs.com/advisories/788
  * https://npmjs.com/advisories/813
* Updated stylelint-config-wikimedia to 0.6.0, addressing:
  * https://npmjs.com/advisories/786

Committed package-lock.json (T179229) too.

Change-Id: If1b025d8223766073a58e54164c36e663d346676
2019-06-07 18:09:46 +00:00
libraryupgrader
a243d77ce6 build: Updating mediawiki/mediawiki-codesniffer to 26.0.0
Change-Id: I4155fcb3fe280d4f5d46080b9dafd836d9683512
2019-06-07 15:54:14 +00:00
Translation updater bot
d18ffa4779 Localisation updates from https://translatewiki.net.
Change-Id: I9d6bc256cf2223492baacd801bbe485fc162c977
2019-06-06 22:22:13 +02:00
Translation updater bot
bcc8497b45 Localisation updates from https://translatewiki.net.
Change-Id: Ib4036fc581d56d3abb55b7894718a7eb18f107d5
2019-06-02 22:00:57 +02:00
Translation updater bot
58e30f5a92 Localisation updates from https://translatewiki.net.
Change-Id: I018623b3825571634d464ad237598b64975ee3e9
2019-05-30 22:25:01 +02:00
Translation updater bot
e577ec8b9f Localisation updates from https://translatewiki.net.
Change-Id: Icdfa6b85a5098f7da92e06b8a37c43fb2ced38d8
2019-05-23 22:42:28 +02:00
James D. Forrester
f8b08d09d3 build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0
Change-Id: Ic32748529c65b8e75fbb93cd88c0fd70edaeaf6d
2019-05-19 18:59:48 +00:00
Jack Phoenix
1bb0c40a49 Remove last references to the long-gone CSS classes .editExternally and .editExternallyHelp
See core commit 1890f315a2d756b9fa31856f59437ade8aafea7a for the full explanation, but tl,dr: these classes haven't been used since 2005.

Change-Id: I52d7facccce955da9f66102b657a0e3627904167
2019-04-21 00:05:04 +03:00
Translation updater bot
770529238a Localisation updates from https://translatewiki.net.
Change-Id: I5c5765061822d0069cb1e1f512165ab618b08c32
2019-04-14 22:03:34 +02:00
Volker E
7698e737bf Remove list-style-image fallback treatment for non-SVG browsers
Bug: T220327
Change-Id: I421716a8d964be4676a82b39446dd78ac78b7fba
2019-04-07 23:15:31 -07:00
Kunal Mehta
1c67fac1b4 Upgrade to newer phan
Change-Id: Idb1940b42d85afb80422c4f10a50942464c3afba
2019-03-20 19:43:14 -07:00
Ed Sanders
244bc6b050 build: Update eslint-config-wikimedia to 0.11.0
Change-Id: I408ff717768a00de74868b52d390dcc4b3269bcd
2019-03-13 22:57:00 +00:00
Translation updater bot
6a9a3764a5 Localisation updates from https://translatewiki.net.
Change-Id: I23beb11b1b06d4862bc4cb4f0f8c78474cf52210
2019-03-05 22:09:55 +01:00
Translation updater bot
c11088277e Localisation updates from https://translatewiki.net.
Change-Id: I469851e71737636e68ff45d3dc5c701989fe1c46
2019-02-18 22:08:36 +01:00
Translation updater bot
ed991bf71d Localisation updates from https://translatewiki.net.
Change-Id: I00d50fdcf32d103f84b6886ba29784f75cbf063d
2019-02-14 22:11:57 +01:00
Volker E
0e863dabc4 Remove 'icons-sourcefile.svg'
Removing file originally intended to create icons.

Change-Id: I5cc884c5ea4133a2b9dd7f97db1464405226fd07
2019-02-08 14:17:18 -08:00
Volker E
523c7e0716 build: Add Grunt 'svgmin' task and crush SVGs
Adding 'grunt-svgmin' package and corresponding 'svgmin' task and
also crush in-use SVGs.

Bug: T215485
Change-Id: I3a8ba3daab7b7fb110000d88d9baff9ea1f5b5db
2019-02-08 14:11:03 -08:00
libraryupgrader
3639907690 build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: Icb4a1b18db31acfbbeaa24364ac3e230a0e63851
2019-02-06 08:07:00 +00:00
Translation updater bot
3711ec0541 Localisation updates from https://translatewiki.net.
Change-Id: I9b5c437362ec44aa17749fd9fb845531a8004fc9
2019-01-30 21:56:09 +01:00
Translation updater bot
9b6bbe8754 Localisation updates from https://translatewiki.net.
Change-Id: I42a9db811dd757c18400e31892d104f9a9960cb2
2019-01-28 22:11:46 +01:00
Isarra
1efe5cbc59 Target desktop only for ULS mobile styles, as the ULS styles themselves do
Per Jon's comments here:
https://gerrit.wikimedia.org/r/c/mediawiki/skins/MonoBook/+/434159/1/includes/SkinMonoBook.php#99

Change-Id: Ie91ecd50726b62ce2e8261c40a6a684d879d9c87
2019-01-24 23:16:30 +00:00
jenkins-bot
21e5fcd792 Merge "Put background images back in single set of declarations in body" 2019-01-22 01:40:53 +00:00
Isarra
e9b62baf8d Put background images back in single set of declarations in body
Separating the two background images out is unnecessary when we already
have a single-image fallback jpeg for old browsers, and also breaks
extensions such as Theme and user/site css affecting the background image.

Change-Id: Ic869b84fb6d0c10b91a171fb1f842e2290d3bc0a
2019-01-22 02:34:52 +01:00
Translation updater bot
0e7530daab Localisation updates from https://translatewiki.net.
Change-Id: Icb08a409b052a8acafca65acfa5f5bb6d808a8e5
2019-01-18 21:56:54 +01:00
Ed Sanders
7712f1bf22 build: Update eslint-config-wikimedia to 0.10.0
Change-Id: I58983b156eab7090c245ad6febfa47f1552c7188
2019-01-14 21:00:07 +00:00
Translation updater bot
72aa634561 Localisation updates from https://translatewiki.net.
Change-Id: I82e1feeb75ece06cbcdf5cd4596b392bee4987e7
2019-01-07 22:21:56 +01:00
Isarra
0221daf6ae Fix disappearing page tab issue in mobile
bug: T211378
Change-Id: If69c0c1ed134f2bff1b453ccd853c826d1da07dc
2019-01-06 17:29:18 +00:00
Volker E
af18fc71e5 build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Change-Id: I409d8b260ef56f0ab09619968d513cae71d43471
2018-12-08 12:24:55 -08:00
libraryupgrader
e7d7d0ef20 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I821fdc01cd3a45519fefa9f00171d9df25b894c9
2018-11-14 05:59:39 +00:00
Translation updater bot
108cde357a Localisation updates from https://translatewiki.net.
Change-Id: I02b6e823e6e4da08d0a58ed86f81b7b0b397bba2
2018-11-12 21:58:12 +01:00
Volker E
d2a20bd520 Remove obsolete Special:Preferences styles after its transformation to OOUI
These removed styles match no elements in the
Special:Preferences page since the OOUI transformation.

Bug: T208923
Change-Id: If7df130c53bcbbc199a6e10a6d84dbcc8b4e087d
2018-11-07 12:53:36 -08:00