From dd1cb0dfad2565d8fecab31887c6753e88b82685 Mon Sep 17 00:00:00 2001 From: Jack Phoenix Date: Tue, 24 Jan 2017 17:25:26 +0200 Subject: [PATCH] Random coding style tweaks + documentation clarification Change-Id: I3d7946507bd489edf248c201877fab580875ed68 --- MonoBookTemplate.php | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/MonoBookTemplate.php b/MonoBookTemplate.php index a1bda6e..58453ac 100644 --- a/MonoBookTemplate.php +++ b/MonoBookTemplate.php @@ -101,8 +101,7 @@ class MonoBookTemplate extends BaseTemplate { data['dataAfterContent'] ) { - $this->html( 'dataAfterContent' - ); + $this->html( 'dataAfterContent' ); } ?>
@@ -122,8 +121,8 @@ class MonoBookTemplate extends BaseTemplate { $personalTools = $this->getPersonalTools(); if ( array_key_exists( 'uls', $personalTools ) ) { - echo $this->makeListItem( 'uls', $personalTools[ 'uls' ] ); - unset( $personalTools[ 'uls' ] ); + echo $this->makeListItem( 'uls', $personalTools['uls'] ); + unset( $personalTools['uls'] ); } if ( !$this->getSkin()->getUser()->isLoggedIn() && @@ -132,7 +131,6 @@ class MonoBookTemplate extends BaseTemplate { echo Html::rawElement( 'li', array( 'id' => 'pt-anonuserpage' ), $this->getMsg( 'notloggedin' )->escaped() ); - } foreach ( $personalTools as $key => $item ) { ?> @@ -160,8 +158,8 @@ class MonoBookTemplate extends BaseTemplate {
getFooterIcons( "icononly" ); - $validFooterLinks = $this->getFooterLinks( "flat" ); // Additional footer links + $validFooterIcons = $this->getFooterIcons( 'icononly' ); + $validFooterLinks = $this->getFooterLinks( 'flat' ); // Additional footer links if ( count( $validFooterIcons ) + count( $validFooterLinks ) > 0 ) { ?> @@ -254,20 +252,20 @@ class MonoBookTemplate extends BaseTemplate {
- - makeSearchInput( array( "id" => "searchInput" ) ); ?> + + makeSearchInput( array( 'id' => 'searchInput' ) ); ?> makeSearchButton( - "go", - array( "id" => "searchGoButton", "class" => "searchButton" ) + 'go', + array( 'id' => 'searchGoButton', 'class' => 'searchButton' ) ); if ( $this->config->get( 'UseTwoButtonsSearchForm' ) ) { ?>  makeSearchButton( - "fulltext", - array( "id" => "mw-searchButton", "class" => "searchButton" ) + 'fulltext', + array( 'id' => 'mw-searchButton', 'class' => 'searchButton' ) ); } else { ?> @@ -286,7 +284,7 @@ class MonoBookTemplate extends BaseTemplate { } /** - * Prints the cactions bar. + * Prints the content actions (cactions) bar. * Shared between MonoBook and Modern */ function cactions() { @@ -342,8 +340,8 @@ class MonoBookTemplate extends BaseTemplate {
    - data['language_urls'] as $key => $langlink ) { ?> - makeListItem( $key, $langlink ); ?> + data['language_urls'] as $key => $langLink ) { ?> + makeListItem( $key, $langLink ); ?>

    exists() ? $msgObj->text() : $bar ); ?>

    -
    +