From b3847eaa952d933d7ef63a80fbe0395550f3a788 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Mon, 24 Feb 2020 14:15:03 -0800 Subject: [PATCH] Get legacy styles from ResourceLoaderSkinModule Instead of relying on Skin::getDefaultModules to get `mediawiki.legacy.styles` make the legacy style feature an explicit opt in choice by including it in the features list. This is done on the assumption that Icb910a563273bde92a09b1bb92857d5b6e348baa will shortly be merged to deprecate this module to avoid double loading the styles. Bug: T242177 Depends-On: Icb910a563273bde92a09b1bb92857d5b6e348baa Change-Id: I6471bc169f3c2a1f51e17b8ee26ac245b0374c18 --- skin.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/skin.json b/skin.json index ae1075e..5281ebc 100644 --- a/skin.json +++ b/skin.json @@ -34,7 +34,7 @@ "ResourceModules": { "skins.monobook.styles": { "class": "ResourceLoaderSkinModule", - "features": [ "elements", "content", "interface", "logo" ], + "features": [ "elements", "content", "interface", "logo", "legacy" ], "styles": { "resources/screen-common.less": { "media": "screen" @@ -50,6 +50,7 @@ "elements", "content", "interface", + "legacy", "logo" ], "targets": [ @@ -69,10 +70,9 @@ } }, "skins.monobook.mobile": { - "targets": [ - "desktop", - "mobile" - ], + "class": "ResourceLoaderSkinModule", + "features": [ "elements", "content", "interface", "logo", "legacy" ], + "targets": [ "desktop", "mobile" ], "scripts": [ "resources/mobile.js" ],