From bbcdc2be11648c9b59968d9172e295ef8ca0f4c1 Mon Sep 17 00:00:00 2001 From: Baptiste Augrain Date: Sat, 18 Dec 2021 10:24:44 +0100 Subject: [PATCH] fix(snap): add missing icons and add review before publish (#957) --- .github/workflows/linux.yml | 5 +++++ stores/snapcraft/snap/snapcraft.yaml | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 05191a3..7345b7a 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -130,6 +130,11 @@ jobs: id: build if: env.SHOULD_DEPLOY == 'yes' + - uses: diddlesnaps/snapcraft-review-action@v1 + with: + snap: ${{ steps.build.outputs.snap }} + isClassic: 'true' + - uses: snapcore/action-publish@v1 with: store_login: ${{ secrets.SNAP_STORE_LOGIN }} diff --git a/stores/snapcraft/snap/snapcraft.yaml b/stores/snapcraft/snap/snapcraft.yaml index 4f50ae3..0499719 100644 --- a/stores/snapcraft/snap/snapcraft.yaml +++ b/stores/snapcraft/snap/snapcraft.yaml @@ -52,6 +52,7 @@ parts: - libpcre3 - libpulse0 - libsecret-1-0 + - libxshmfence1 - libxss1 - libxtst6 - zlib1g @@ -77,13 +78,14 @@ parts: apps: codium: command: electron-launch $SNAP/usr/share/codium/bin/codium --no-sandbox - common-id: codium.desktop + desktop: usr/share/applications/codium.desktop environment: DISABLE_WAYLAND: 1 GSETTINGS_SCHEMA_DIR: $SNAP/usr/share/glib-2.0/schemas url-handler: command: electron-launch $SNAP/usr/share/codium/bin/codium --open-url --no-sandbox + desktop: usr/share/applications/codium-url-handler.desktop environment: DISABLE_WAYLAND: 1 GSETTINGS_SCHEMA_DIR: $SNAP/usr/share/glib-2.0/schemas