From 85a26a52944c89af273bc974380b438073280981 Mon Sep 17 00:00:00 2001
From: extremeheat <extreme@protonmail.ch>
Date: Sun, 11 Feb 2024 09:55:15 -0500
Subject: [PATCH] Ensure `onReady` in client is called once (#1287)

Fix https://github.com/PrismarineJS/node-minecraft-protocol/issues/1286

Server sending start_config packets will incorrectly cause onReady to call multiple times
---
 src/client/play.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/client/play.js b/src/client/play.js
index 2f2c587..246556e 100644
--- a/src/client/play.js
+++ b/src/client/play.js
@@ -37,15 +37,15 @@ module.exports = function (client, options) {
 
     if (mcData.supportFeature('hasConfigurationState')) {
       client.write('login_acknowledged', {})
-      enterConfigState()
+      enterConfigState(onReady)
       // Server can tell client to re-enter config state
-      client.on('start_configuration', enterConfigState)
+      client.on('start_configuration', () => enterConfigState())
     } else {
       client.state = states.PLAY
       onReady()
     }
 
-    function enterConfigState () {
+    function enterConfigState (finishCb) {
       if (client.state === states.CONFIGURATION) return
       // If we are returning to the configuration state from the play state, we ahve to acknowledge it.
       if (client.state === states.PLAY) {
@@ -57,7 +57,7 @@ module.exports = function (client, options) {
       client.once('finish_configuration', () => {
         client.write('finish_configuration', {})
         client.state = states.PLAY
-        onReady()
+        finishCb?.()
       })
     }