Parker2991/node-minecraft-protocol
1
0
Fork 0
mirror of https://github.com/PrismarineJS/node-minecraft-protocol.git synced 2024-11-14 19:04:59 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #581 from lluiscab/patch-2

Browse source 
Fix: Join specified server if SRV records could not be resolved
This commit is contained in:
Romain Beaumont 2018-08-26 01:42:29 +02:00 committed by GitHub
commit 0fde94e7d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/client/tcp_dns.js
View file

@ -2,26 +2,44 @@ const net = require('net')
const dns = require('dns')
module.exports = function (client, options) {
// Default options
options.port = options.port || 25565
options.host = options.host || 'localhost'
if (!options.connect) {
options.connect = (client) => {
// Use stream if provided
if (options.stream) {
client.setSocket(options.stream)
client.emit('connect')
} else if (options.port === 25565 && net.isIP(options.host) === 0 && options.host !== 'localhost') {
dns.resolveSrv('_minecraft._tcp.' + options.host, function (err, addresses) {
return
}
// If port was not defined (defauls to 25565), host is not an ip neither localhost
if (options.port === 25565 && net.isIP(options.host) === 0 && options.host !== 'localhost') {
// Try to resolve SRV records for the comain
dns.resolveSrv('_minecraft._tcp.' + options.host, (err, addresses) => {
// Error resolving domain
if (err) {
console.log(err)
// Could not resolve SRV lookup, connect directly
if (err.code === 'ENODATA') {
client.setSocket(net.connect(options.port, options.host))
return
} else {
// Something else happened
return client.emit('error', err)
}
}
// SRV Lookup resolved conrrectly
if (addresses && addresses.length > 0) {
client.setSocket(net.connect(addresses[0].port, addresses[0].name))
} else {
client.setSocket(net.connect(options.port, options.host))
client.emit('error', new Error('Could not resolve hostname'))
}
})
} else {
// Otherwise, just connect using the provided hostname and port
client.setSocket(net.connect(options.port, options.host))
}
}