Parker2991/MCProtocolLib
1
0
Fork 0
mirror of https://github.com/GeyserMC/MCProtocolLib.git synced 2025-03-13 22:49:51 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix readVarLong, remove multiplication in readVarInt

Browse source
This commit is contained in:
valaphee 2024-08-19 14:37:45 +02:00
parent bb38c8ad9a
commit c2795892fd
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
protocol/src/main/java/org/geysermc/mcprotocollib/network/codec/BasePacketCodecHelper.java
View file

@ -18,13 +18,14 @@ public class BasePacketCodecHelper implements PacketCodecHelper {
int size = 0;
int b;
while (((b = buf.readByte()) & 0x80) == 0x80) {
value |= (b & 0x7F) << (size++ * 7);
if (size > 5) {
throw new IllegalArgumentException("VarInt too long (length must be <= 5)");
value |= (b & 0x7F) << size;
size += 7;
if (size > 35) {
throw new IllegalArgumentException("VarInt wider than 35-bit");
}
}
return value | ((b & 0x7F) << (size * 7));
return value | ((b & 0x7F) << size);
}
// Based off of Andrew Steinborn's blog post:
@ -127,17 +128,18 @@ public class BasePacketCodecHelper implements PacketCodecHelper {
@Override
public long readVarLong(ByteBuf buf) {
int value = 0;
long value = 0;
int size = 0;
int b;
while (((b = buf.readByte()) & 0x80) == 0x80) {
value |= (b & 0x7F) << (size++ * 7);
if (size > 10) {
throw new IllegalArgumentException("VarLong too long (length must be <= 10)");
value |= (b & 0x7FL) << size;
size += 7;
if (size > 70) {
throw new IllegalArgumentException("VarLong wider than 70-bit");
}
}
return value | ((b & 0x7FL) << (size * 7));
return value | ((b & 0x7FL) << size);
}
@Override