From d44275c2c7050ed207cb031328f0d9966b812c85 Mon Sep 17 00:00:00 2001
From: EliteMasterEric <ericmyllyoja@gmail.com>
Date: Sun, 16 Jun 2024 18:34:10 -0400
Subject: [PATCH] Fix a bug where songs with no notes would crash the results
screen.
---
source/funkin/play/ResultState.hx | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/source/funkin/play/ResultState.hx b/source/funkin/play/ResultState.hx
index 48fb3b04e..a2c5f7e62 100644
--- a/source/funkin/play/ResultState.hx
+++ b/source/funkin/play/ResultState.hx
@@ -464,7 +464,9 @@ class ResultState extends MusicBeatSubState
{
bgFlash.visible = true;
FlxTween.tween(bgFlash, {alpha: 0}, 5 / 24);
- var clearPercentFloat = (params.scoreData.tallies.sick + params.scoreData.tallies.good) / params.scoreData.tallies.totalNotes * 100;
+ // NOTE: Only divide if totalNotes > 0 to prevent divide-by-zero errors.
+ var clearPercentFloat = params.scoreData.tallies.totalNotes == 0 ? 0.0 : (params.scoreData.tallies.sick +
+ params.scoreData.tallies.good) / params.scoreData.tallies.totalNotes * 100;
clearPercentTarget = Math.floor(clearPercentFloat);
// Prevent off-by-one errors.