Parker2991/Funkin
1
0
Fork 0
mirror of https://github.com/FunkinCrew/Funkin.git synced 2024-11-14 19:25:16 -05:00
Code Issues Projects Releases Packages Wiki Activity

applySongRank fix

Browse source 
fixes the bug with the percent being overriden when the song has the same letter rank but lower percent (eg. E Rank with 99% being overriden by E Rank with 93%)
This commit is contained in:
Kolo 2024-09-18 13:40:02 +02:00 committed by GitHub
parent a27c4ae24f
commit a4b59d14bf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
source/funkin/save/Save.hx
View file

@ -598,11 +598,15 @@ class Save
return;
}
//percent also accounts for different ranks
var oldPerc = (previousScoreData.tallies.sick + previousScoreData.tallies.good) / previousScoreData.tallies.totalNotes;
var newPerc = (newScoreData.tallies.sick + newScoreData.tallies.good) / newScoreData.tallies.totalNotes;
// Set the high score and the high rank separately.
var newScore:SaveScoreData =
{
score: (previousScoreData.score > newScoreData.score) ? previousScoreData.score : newScoreData.score,
tallies: (previousRank > newRank) ? previousScoreData.tallies : newScoreData.tallies
score: Std.int(Math.max(previousScoreData.score, newScoreData.score)),
tallies: (oldPerc > newPerc ? previousScoreData.tallies : newScoreData.tallies)
};
song.set(difficultyId, newScore);