Merge pull request #363 from FunkinCrew/bugfix/chart-editor-vocal-crash

Fix a bug where Chart Editor Playtest destroys the vocals and crashes
This commit is contained in:
Cameron Taylor 2024-03-05 14:35:15 -05:00 committed by GitHub
commit 95138d0386

View file

@ -2791,14 +2791,19 @@ class PlayState extends MusicBeatSubState
// TODO: Uncache the song. // TODO: Uncache the song.
} }
if (!overrideMusic) if (overrideMusic)
{ {
// Stop the music. // Stop the music. Do NOT destroy it, something still references it!
FlxG.sound.music.pause(); FlxG.sound.music.pause();
if (vocals != null) vocals.stop(); if (vocals != null)
{
vocals.pause();
remove(vocals);
}
} }
else else
{ {
// Stop and destroy the music.
FlxG.sound.music.pause(); FlxG.sound.music.pause();
if (vocals != null) if (vocals != null)
{ {