From c1c2621e1d2412994863360e21701e1faf9823b0 Mon Sep 17 00:00:00 2001
From: EliteMasterEric <ericmyllyoja@gmail.com>
Date: Thu, 28 Mar 2024 00:18:39 -0400
Subject: [PATCH 1/2] Fix bug where Bad and Shit didn't count at Notes Hit in
the results screen.
---
source/funkin/play/PlayState.hx | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/source/funkin/play/PlayState.hx b/source/funkin/play/PlayState.hx
index 6dc41e3f9..1cf69489d 100644
--- a/source/funkin/play/PlayState.hx
+++ b/source/funkin/play/PlayState.hx
@@ -2568,32 +2568,38 @@ class PlayState extends MusicBeatSubState
*/
function popUpScore(daNote:NoteSprite, score:Int, daRating:String, healthChange:Float):Void
{
- vocals.playerVolume = 1;
-
if (daRating == 'miss')
{
// If daRating is 'miss', that means we made a mistake and should not continue.
- trace('[WARNING] popUpScore judged a note as a miss!');
+ FlxG.log.warn('popUpScore judged a note as a miss!');
// TODO: Remove this.
comboPopUps.displayRating('miss');
return;
}
+ vocals.playerVolume = 1;
+
var isComboBreak = false;
switch (daRating)
{
case 'sick':
Highscore.tallies.sick += 1;
+ Highscore.tallies.totalNotesHit++;
isComboBreak = Constants.JUDGEMENT_SICK_COMBO_BREAK;
case 'good':
Highscore.tallies.good += 1;
+ Highscore.tallies.totalNotesHit++;
isComboBreak = Constants.JUDGEMENT_GOOD_COMBO_BREAK;
case 'bad':
Highscore.tallies.bad += 1;
+ Highscore.tallies.totalNotesHit++;
isComboBreak = Constants.JUDGEMENT_BAD_COMBO_BREAK;
case 'shit':
Highscore.tallies.shit += 1;
+ Highscore.tallies.totalNotesHit++;
isComboBreak = Constants.JUDGEMENT_SHIT_COMBO_BREAK;
+ default:
+ FlxG.log.error('Wuh? Buh? Guh? Note hit judgement was $daRating!');
}
health += healthChange;
From 837fcee98386cb150cb6e633054b4bb3b0900519 Mon Sep 17 00:00:00 2001
From: EliteMasterEric <ericmyllyoja@gmail.com>
Date: Thu, 28 Mar 2024 00:19:57 -0400
Subject: [PATCH 2/2] Fix a bug where 000 would display any time a Bad or Shit
is hit (instead of just when a combo break is hit)
---
source/funkin/play/PlayState.hx | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/source/funkin/play/PlayState.hx b/source/funkin/play/PlayState.hx
index 1cf69489d..a161c04c5 100644
--- a/source/funkin/play/PlayState.hx
+++ b/source/funkin/play/PlayState.hx
@@ -2441,7 +2441,8 @@ class PlayState extends MusicBeatSubState
if (Highscore.tallies.combo != 0)
{
// Break the combo.
- Highscore.tallies.combo = comboPopUps.displayCombo(0);
+ if (Highscore.tallies.combo >= 10) comboPopUps.displayCombo(0);
+ Highscore.tallies.combo = 0;
}
if (playSound)
@@ -2607,18 +2608,18 @@ class PlayState extends MusicBeatSubState
if (isComboBreak)
{
// Break the combo, but don't increment tallies.misses.
- Highscore.tallies.combo = comboPopUps.displayCombo(0);
+ if (Highscore.tallies.combo >= 10) comboPopUps.displayCombo(0);
+ Highscore.tallies.combo = 0;
}
else
{
Highscore.tallies.combo++;
- Highscore.tallies.totalNotesHit++;
if (Highscore.tallies.combo > Highscore.tallies.maxCombo) Highscore.tallies.maxCombo = Highscore.tallies.combo;
}
playerStrumline.hitNote(daNote, !isComboBreak);
- if (daRating == "sick")
+ if (daRating == 'sick')
{
playerStrumline.playNoteSplash(daNote.noteData.getDirection());
}