Parker2991/Funkin
1
0
Fork 0
mirror of https://github.com/FunkinCrew/Funkin.git synced 2025-01-07 05:22:11 -05:00
Code Issues Projects Releases Packages Wiki Activity

[BUGFIX] Prevented infinite recursion on freeplay when a song doesn't have the normal difficulty

Browse source 
Any attempt to create a song without the `normal` difficulty will result in a silent crash when opening freeplay. After some debugging, I discovered that the issue is caused by infinite recursion, which gets triggered at the start of `FreeplaySongData`'s `updateValues`.
This commit is contained in:
AppleHair 2024-07-16 21:17:53 +03:00 committed by GitHub
parent 9b483de1da
commit 5e1d25e791
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
source/funkin/ui/freeplay/FreeplayState.hx
View file

@ -2077,7 +2077,11 @@ class FreeplaySongData
function updateValues(variations:Array<String>):Void function updateValues(variations:Array<String>):Void
{ {
this.songDifficulties = song.listDifficulties(null, variations, false, false); this.songDifficulties = song.listDifficulties(null, variations, false, false);
if (!this.songDifficulties.contains(currentDifficulty)) currentDifficulty = Constants.DEFAULT_DIFFICULTY; if (!this.songDifficulties.contains(currentDifficulty) && currentDifficulty != Constants.DEFAULT_DIFFICULTY)
{
currentDifficulty = Constants.DEFAULT_DIFFICULTY;
return;
}
var songDifficulty:SongDifficulty = song.getDifficulty(currentDifficulty, null, variations); var songDifficulty:SongDifficulty = song.getDifficulty(currentDifficulty, null, variations);
if (songDifficulty == null) return; if (songDifficulty == null) return;