Parker2991/Funkin
1
0
Fork 0
mirror of https://github.com/FunkinCrew/Funkin.git synced 2024-11-30 03:25:47 -05:00
Code Issues Projects Releases Packages Wiki Activity

WIP

Browse source
This commit is contained in:
EliteMasterEric 2024-01-15 14:20:44 -05:00
parent 5dbed6d4dd
commit 313fd55e98
3 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
source/funkin/play/PlayState.hx
View file

@ -1796,6 +1796,7 @@ class PlayState extends MusicBeatSubState
{ {
if (note == null) continue; if (note == null) continue;
// TODO: Does this properly account for offsets?
var hitWindowStart = note.strumTime - Constants.HIT_WINDOW_MS; var hitWindowStart = note.strumTime - Constants.HIT_WINDOW_MS;
var hitWindowCenter = note.strumTime; var hitWindowCenter = note.strumTime;
var hitWindowEnd = note.strumTime + Constants.HIT_WINDOW_MS; var hitWindowEnd = note.strumTime + Constants.HIT_WINDOW_MS;
@ -1865,7 +1866,10 @@ class PlayState extends MusicBeatSubState
} }
// TODO: Potential penalty for dropping a hold note? // TODO: Potential penalty for dropping a hold note?
// if (holdNote.missedNote && !holdNote.handledMiss) { holdNote.handledMiss = true; } if (holdNote.missedNote && !holdNote.handledMiss)
{
holdNote.handledMiss = true;
}
} }
// Process notes on the player's side. // Process notes on the player's side.

2
source/funkin/play/notes/Strumline.hx
View file

@ -343,7 +343,7 @@ class Strumline extends FlxSpriteGroup
playStatic(holdNote.noteDirection); playStatic(holdNote.noteDirection);
holdNote.missedNote = true; holdNote.missedNote = true;
holdNote.visible = true; holdNote.visible = true;
holdNote.alpha = 0.0; holdNote.alpha = 0.0; // Completely hide the dropped hold note.
} }
} }

5
source/funkin/play/notes/SustainTrail.hx
View file

@ -47,6 +47,11 @@ class SustainTrail extends FlxSprite
*/ */
public var missedNote:Bool = false; public var missedNote:Bool = false;
/**
* Set to `true` after handling additional logic for missing notes.
*/
public var handledMiss:Bool = false;
// maybe BlendMode.MULTIPLY if missed somehow, drawTriangles does not support! // maybe BlendMode.MULTIPLY if missed somehow, drawTriangles does not support!
/** /**