Parker2991/Funkin
1
0
Fork 0
mirror of https://github.com/FunkinCrew/Funkin.git synced 2025-05-21 10:12:12 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request from FunkinCrew/lemz1/completion-fix

Browse source 
[PUBLIC PR] Fix an issue where getting the same rank (but a different clear %) will override the rating
This commit is contained in:
Cameron Taylor 2024-09-27 16:50:53 -04:00 • committed by GitHub
commit 06fee5599c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions

5
source/funkin/save/Save.hx
View file

@ -603,11 +603,14 @@ class Save
return; return;
} }
var newCompletion = (newScoreData.tallies.sick + newScoreData.tallies.good) / newScoreData.tallies.totalNotes;
var previousCompletion = (previousScoreData.tallies.sick + previousScoreData.tallies.good) / previousScoreData.tallies.totalNotes;
// Set the high score and the high rank separately. // Set the high score and the high rank separately.
var newScore:SaveScoreData = var newScore:SaveScoreData =
{ {
score: (previousScoreData.score > newScoreData.score) ? previousScoreData.score : newScoreData.score, score: (previousScoreData.score > newScoreData.score) ? previousScoreData.score : newScoreData.score,
tallies: (previousRank > newRank) ? previousScoreData.tallies : newScoreData.tallies tallies: (previousRank > newRank || previousCompletion > newCompletion) ? previousScoreData.tallies : newScoreData.tallies
}; };
song.set(difficultyId, newScore); song.set(difficultyId, newScore);