Commit graph

40 commits

Author SHA1 Message Date
Technici4n
9386d8a793
Model Loading API v1 (#3145)
This PR deprecates and supersedes the old `fabric-models-v0` module.

## Refactors compared to v0
### Model loading hooks
Mods now register a single `ModelLoadingPlugin` for any change they want to make to the model loading process. (Or multiple plugins if they want to). This replaces the old `ModelLoadingRegistry`.

Here is an example:

```java
ModelLoadingPlugin.register(pluginContext -> {
    // ResourceManager access is provided like in the v0 API, but in a central place, and can be used for shared processing in the plugin.
    ResourceManager manager = pluginContext.resourceManager();

    // Model resource providers still exist, but they are called model resolvers now
    pluginContext.resolveModel().register(context -> {
        // ...
    });
});
```

#### `ModelVariantProvider` -> `BlockStateResolver`
`ModelVariantProvider` was heavily reworked, and is now replaced by the `BlockStateResolver`, with a much better defined contract.

#### `ModelResourceProvider` -> `ModelResolver`
The resource provider is mostly unchanged. The biggest difference is that it is now registered as an event listener. This allows mods to use event phases for ordering between conflicting ~~providers~~ resolvers.

#### Removed custom exception
Additionally, `ModelProviderException` could be thrown by a variant or resource provider in the v0 API. This was not explained in the documentation, and would according to the code stop further processing of the providers and log an error.

In the new API, any `Exception` is caught and logged. If that happens, the other resolvers are still processed. There is no custom `Exception` subclass anymore.

### Helper method to get a `BakedModel` by `Identifier` from the manager
The v0 had such a method in a helper class: `BakedModelManagerHelper#getBakedModel`. It is now interface-injected instead. See `FabricBakedModelManager`.

## New model wrapping hooks
New hooks are added for the various needs of mods that want to override or wrap specific models. Thanks to @embeddedt for contributing an initial version of them!

Here is an example of wrapping the gold model to remove the bottom quads, for example:
```java
ModelLoadingPlugin.register(pluginContext -> {
	// remove bottom face of gold blocks
	pluginContext.modifyModelAfterBake().register(ModelModifier.WRAP_PHASE, (model, context) -> {
		if (context.identifier().getPath().equals("block/gold_block")) {
			return new DownQuadRemovingModel(model);
		} else {
			return model;
		}
	});
});
```

There are 3 events, for the following use cases:
- Wrapping `UnbakedModel`s right when they are loaded. This allows replacing them entirely in dependent models too.
- Wrapping `UnbakedModel`s right before they are baked. This allows replacing them without affecting dependent models (which might not be expecting a model class change).
- Wrapping `BakedModel`s right when they are baked.

Multiple mods have implemented their own version of them. Providing them in Fabric API will make it easier on these mods, and will additionally allow optimization mods that perform on-demand model loading to simply fire the hooks themselves instead of working around injections performed by other mods.

Co-authored-by: embeddedt <42941056+embeddedt@users.noreply.github.com>
Co-authored-by: PepperCode1 <44146161+PepperCode1@users.noreply.github.com>
Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com>
2023-07-18 12:53:13 +01:00
modmuss
b3afc78b68
Setup unit tests & format gradle files. (#3073) 2023-05-30 13:07:11 +01:00
Technici4n
12bfe4ea1a
Add a block appearance API (#2579)
* Add block appearance API

* Add class javadoc for FabricBlock and FabricBlockState

* Address reviews

* Remove OverrideOnly from getAppearance

* Fix javadoc issues
2022-11-07 18:29:51 +00:00
modmuss50
9ff28f4026
Split client only code into its own sourceset. (#2179)
A common source of crashes on modded Minecraft servers comes from modders accidently calling client only code from the client, this PR is another large step towards elimitating that.

This PR has been months in the making and years in the planning, requiring major changes to Loom & Loader. In recent Minecraft versions Mojang has made it easier than ever to cleanly split the jar, going against the status-quo of merging the client and server into one jar.

From the start we have designed Fabric to have a very clear split between client and common (client & server) code. Fabric has always encoraged keeping client only code seprate from the server, this can be seen at a fundamental level with the entrypoints in Loader. Fabric API's have all been designed with this mind.

This PR provides a compile safety net around Fabric API using client only code on the server. Even though there are almost 400 changed files, minimal changes beyond moving the files were required to achieve this in Fabric API, thanks to the effort of all contributors in the past.

These changes should not affect modders or players in anyway, a single "universal" jar is still produced. Im happy to awnswer any questions.
2022-05-21 16:26:46 +01:00
modmuss50
d882b91555
Port to 22w06a (#1989)
This snapshot is possibly one of the most impactful for API we have ever had. This PR is an inital port to support 22w06a, stuff will be missing and broken. 

# Removed modules:
- fabric-mining-levels-v0 - Previously deprecated
- fabric-object-builders-v0 - Previously deprecated
- fabric-tag-extensions-v0
- fabric-tool-attribute-api-v1

# Modules with API breaking changes:
- fabric-biome-api-v1
- fabric-content-registries-v0
- fabric-data-generation-api-v1
- fabric-mining-level-api-v1
- fabric-object-builder-api-v1
- fabric-resource-conditions-api-v1
- fabric-structure-api-v1

# Impactful API changes:
### fabric-object-builder-api-v1
- Removed - FabricBlockSettings.breakByHand
- Removed - FabricBlockSettings.breakByTool  - Previously deprecated

# Notable changes

- fabric-registry-sync-v0 moves vanilla's new registry freezing to a later point in time, allowing mods to add to the registry during init.

# Known issues:
- ServerBugfixMixin used to fix https://bugs.mojang.com/browse/MC-195468 has not yet been ported.
2022-02-11 17:02:44 +00:00
modmuss50
b4f4f6cda4 Update Loom and Loader. Cleanup/improve buildscript. 2021-11-12 15:02:54 +00:00
modmuss50
65d505fc8a Bump versions
All of the version need to be bumped due to fabric-api-base being updated, this highlights the need for a better solution.
2021-11-05 17:09:48 +00:00
modmuss50
dc3d5c4769 21w38a 2021-09-23 18:30:50 +01:00
modmuss50
8f2c3e04fb Bump version 2021-09-21 11:41:06 +01:00
modmuss50
5553aff888 21w37a: Compile pass 2021-09-17 18:42:42 +01:00
grondag
5f02c96920
Prevent SpriteFinder from returning Missing sprite for wrong atlas (#1541)
Co-authored-by: grondag <>
2021-07-05 18:47:06 +01:00
Player
676f40fa73 Bump versions 2021-06-10 14:21:32 +02:00
Cool_Mineman
8a5c621a87 Fix #1273 (Make MultipartBakedModel and WeightedBackedModel implement FabricBakedModel properly) (#1301)
* fix #1273

* Expand testmod to test multipart and weighted models with FRAPI submodels

Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com>
2021-06-10 14:09:00 +02:00
modmuss50
a02b4463f9 21w19a 2021-05-12 20:23:04 +01:00
modmuss50
12865e786c Version bump 2021-04-14 20:03:08 +01:00
i509VCB
6a8b6a39c8 Create a simple renderer api testmod (#1295)
* Create a simple renderer api testmod

* Update fabric-renderer-api-v1/src/testmod/java/net/fabricmc/fabric/test/renderer/simple/client/RendererClientTest.java

Co-authored-by: liach <7806504+liach@users.noreply.github.com>

Co-authored-by: liach <7806504+liach@users.noreply.github.com>
(cherry picked from commit b0e4dde51b)
2021-04-14 19:29:28 +01:00
modmuss50
92519afafe Version bump 2021-01-19 19:38:22 +00:00
modmuss50
c6723711fd Bump versions 2020-12-30 17:26:06 +00:00
modmuss50
e1f1abb1c0 20w49a 2020-12-02 19:02:44 +00:00
Thalia Nero
9f7a7423f3 Add module dependencies to maven POM (#1104) 2020-11-15 19:46:01 +00:00
modmuss50
a4467d2a9c Bump version 2020-10-27 18:36:48 +00:00
modmuss50
2b462379ad Bump versions 2020-10-18 18:38:30 +01:00
modmuss50
f8ac1db2b1 Version bump 2020-09-27 12:38:48 +01:00
grondag
8bcfced859
Fix for #987 (#1046)
* Fix #987, simplify geometry tracking, clean up scoping

* Bump indigo version

* Expose improved fromVanilla method

* Strip deprecations in non-API components

* bump renderer api version

* Clear tag for converted quads

Otherwise possible for tags added by transforms to pollute subsequent quads

* Borrow from Canvas - don't set nominal face twice, prevent header state leakage
2020-09-03 19:50:26 +01:00
modmuss50
84cce57f4d 20w19a: Deprecated min/maxDespawnDistance in FabricEntityTypeBuilder as they are no longer applicable to the EntityType.
This was done to keep mod compat and will be removed very shortly. I dont think they were used by many mods (only added in a recent 1.16 snapshot) so I think this is the best course of action.
2020-05-06 18:46:36 +01:00
modmuss50
12a8474c3a Bump versions 2020-04-05 15:12:25 +01:00
modmuss50
2f56dff236 Initial port to 20w09a 2020-02-26 19:10:16 +00:00
modmuss50
7d8ccbd715
Fix ForwardingBakedModel not forwarding isSideLit. Closes #501 (#502)
* Fix ForwardingBakedModel not forwarding isSideLit. Closes #501

* Remove unused DamageModel

* Bump version
2020-02-10 17:07:06 +00:00
modmuss50
aea78a258d 1.15.2 2020-01-21 15:16:39 +00:00
modmuss50
203491ea23 1.15.2-pre1 2020-01-14 20:50:51 +00:00
modmuss50
f3d8141bae 1.15-pre1 2019-11-21 21:04:17 +00:00
modmuss50
12515ed9ee 19w45a 2019-11-07 20:35:26 +00:00
modmuss50
d2e3099f39 19w42a
Includes a work around for the funky rendering issues, this will need looking into some more.
2019-10-16 18:54:16 +01:00
modmuss50
ccd269cfad 19w41a 2019-10-09 19:05:13 +01:00
grondag
32ac36d518
1.14 Updates and Render Fixes (#394)
* Fix EntityRenderDispatcher hook (again)

* Add fabric-particles-v1

* Add a sync() method to BlockEntityClientSerializable

* Prevent CME due to off-thread block entity updates (#367)

* Restore rendering features disabled in first 19w39a release

* Remove rendering stuffs no longer needed due to snapshots

* Bump versions as needed
2019-09-29 18:21:38 -07:00
Modmuss50
9c45b1ef78 Wip 19w39a (#386)
* 19w39a fixes (#387)

* Bump versions

* Breaks: BlockEntityRendererRegistry and EntityRendererRegistry

* Remove broken parts of rendering, bump major version

* Add renderer-registries, replaces broken parts of rendering api

* Slap a band-aid on renderer/Indigo - won't render properly, but runs

* Bump distribution versions, add renderer-registries to main build

* Clean up blockrenderlayer implementation package name
2019-09-28 18:07:04 -07:00
grondag
128a6b25c0
Bump patch number on Renderer API
Neglected to increment this in last PR.  May also fix #379.
2019-09-24 18:36:56 -07:00
grondag
d2ac651a7a
19w38b API Fixes (#370)
* Fix compilation errors (untested)

* Random fixes

* Various modded rendering fixes

* Restore contract of RenderAttachedBlockView

* Bump versions as needed

* Add API for BlockRenderLayer

* Minor format / name cleanup

Will do a more comprehensive pass as part of separate refactor PR

* Bump versions not handled earlier

* Bump loader/mc bounds for dependent modules

* Update fabric-blockrenderlayer-v1/src/main/java/net/fabricmc/fabric/impl/blockrenderlayer/v1/BlockRenderLayerMapImpl.java

Co-Authored-By: liach <7806504+liach@users.noreply.github.com>

* Update fabric-blockrenderlayer-v1/src/main/java/net/fabricmc/fabric/impl/blockrenderlayer/v1/BlockRenderLayerMapImpl.java

Co-Authored-By: liach <7806504+liach@users.noreply.github.com>

* Minor clean ups

* Improve docs, minor format corrections.

* Update MC dependency
2019-09-20 16:50:49 -07:00
grondag
099c1e8b8c Various Indigo Improvements (#295)
- Fix #199 Vanilla Bug: Glowstone creates AO shade
- Fix #289 Rendering on the Cutout and Transparent Layers together interferes with water rendering
- Fix #290 Smooth lighting breaks on continuous angled surfaces
- Fix #291 QuadEmitter not cleared on MeshBuilder.build()
- Fix #292 Render context QuadEmitter crash with flat lighting
- Fix #293 Relax vertex order requirements for modded quads
- Fix swapped color components for grass and other blocks
- Add option to partially support non-standard vertex formats
2019-07-07 23:16:19 +02:00
Adrian Siekierka
02a46d5b29
[#65] Renderer API + Indigo (#189)
Big thanks to Grondag and Player for all the pain and trouble we all went through.
2019-05-18 22:25:27 +02:00