A common source of crashes on modded Minecraft servers comes from modders accidently calling client only code from the client, this PR is another large step towards elimitating that.
This PR has been months in the making and years in the planning, requiring major changes to Loom & Loader. In recent Minecraft versions Mojang has made it easier than ever to cleanly split the jar, going against the status-quo of merging the client and server into one jar.
From the start we have designed Fabric to have a very clear split between client and common (client & server) code. Fabric has always encoraged keeping client only code seprate from the server, this can be seen at a fundamental level with the entrypoints in Loader. Fabric API's have all been designed with this mind.
This PR provides a compile safety net around Fabric API using client only code on the server. Even though there are almost 400 changed files, minimal changes beyond moving the files were required to achieve this in Fabric API, thanks to the effort of all contributors in the past.
These changes should not affect modders or players in anyway, a single "universal" jar is still produced. Im happy to awnswer any questions.
This migrates all uses of v0 networking to v1 api, and changes the readme to not mention networking-v0 in the example for dependencies.
This effectively makes v0 removable if it breaks in the future beyond repair. Though I expect v0 to last quite a bit longer.
(cherry picked from commit bf770ed853)
* Add screen handler API
* Use more descriptive letters for FabricHandledScreens generics
* Add missing Deprecated annotations
* Bump fabric-containers-v0 version
* Remove unused ServerPlayerEntityAccessor
* Remove [Fabric] from log messages
* Convert FabricHandledScreens to a class
* Add dependency on networking-v0
* Resolve threading issues with NetworkingClient
* Use Identifiers instead of int IDs, make ScreenHandlers a class
Also added a private constructor to FabricHandledScreens.
* NetworkingClient -> ClientNetworking
* Use more descriptive names for injections
* Use ID parameter instead of fetching again
* Add clarifying comment
* Port changes from FabLabs
* Fix compilation
* Replace the content of links in FabricHandledScreens for readability
* Sync with FabLabs
* Add test mod
* I suppose IInv shouldn't have CC0 anymore 👀
* Improve logging
- Networking now uses a logger instead of an exception
- The loggers are now suffixed with their side
- Fixed the client unregistered screen message using the title instead of the ID
* Fix test mod on 20w21a
* Fix ExtendedScreenHandlerFactory javadoc referencing old names
* Update test mod to 1.16-pre2
Just a simple mapping update. :)
* Fix incorrect javadoc references to screen-handler-api in containers-v0
* Remove Minecraft exclusion from build.gradle (thanks to Loom 0.4) + testmod change
Resource loader v0 is now testmodRuntimeOnly as it's not needed for compiling.
