A common source of crashes on modded Minecraft servers comes from modders accidently calling client only code from the client, this PR is another large step towards elimitating that.
This PR has been months in the making and years in the planning, requiring major changes to Loom & Loader. In recent Minecraft versions Mojang has made it easier than ever to cleanly split the jar, going against the status-quo of merging the client and server into one jar.
From the start we have designed Fabric to have a very clear split between client and common (client & server) code. Fabric has always encoraged keeping client only code seprate from the server, this can be seen at a fundamental level with the entrypoints in Loader. Fabric API's have all been designed with this mind.
This PR provides a compile safety net around Fabric API using client only code on the server. Even though there are almost 400 changed files, minimal changes beyond moving the files were required to achieve this in Fabric API, thanks to the effort of all contributors in the past.
These changes should not affect modders or players in anyway, a single "universal" jar is still produced. Im happy to awnswer any questions.
Use explicit casts instead of .class.cast in mixins
Reorganize API class, and make it work for any living entity
add LivingEntityFeatureRenderEvents to disable cape rendering
Reorganize/rename hook, and add ALLOW event
Fix missing mixin return & cosmetic adjustements
* Environmental Renderers
* Remove defunt hideClouds and hideWeather
* Pushed missing License
* Push checkstyle fixes
* remove unused
* Unwrapped the test mod sky rendering.
* Added a first attempt at javadoc.
* Forgot a blank line
* Moved Environment references out of class
* Moved Lamda functions for fog override, thick fog usage and fog color adjustment to their own interfaces and gave them proper javadoc.
* Made FabricSkyProperties private
* PURGE THE H...I mean FabricSkyPropertyBuilder and FabricSkyProperties.
- Reverted unintentional mixin changes
- Fix various typo errors that were pointed out.
- Added missing javadocs and added the ability to override.
* Forgot some pluggin in some overrides.
* Added missing javadoc suggestion
* Changed api a bit so that it fires a exception if renderer not being overridden and one already exists.
* Split Implemtnation and Interface
* Forgot a license
* Added WorldRenderContext to Renderers
* Added logging
* Added missing javadocs and removed the override option.
* Removed INSTANCE
* Environmental Renderers
* Remove defunt hideClouds and hideWeather
* Pushed missing License
* Push checkstyle fixes
* remove unused
* Unwrapped the test mod sky rendering.
* Added a first attempt at javadoc.
* Forgot a blank line
* Moved Environment references out of class
* Moved Lamda functions for fog override, thick fog usage and fog color adjustment to their own interfaces and gave them proper javadoc.
* Made FabricSkyProperties private
* PURGE THE H...I mean FabricSkyPropertyBuilder and FabricSkyProperties.
- Reverted unintentional mixin changes
- Fix various typo errors that were pointed out.
- Added missing javadocs and added the ability to override.
* Forgot some pluggin in some overrides.
* Added missing javadoc suggestion
* Changed api a bit so that it fires a exception if renderer not being overridden and one already exists.
* Split Implemtnation and Interface
* Forgot a license
* Added WorldRenderContext to Renderers
* Added logging
* Added missing javadocs and removed the override option.
* Removed INSTANCE
* Fixed Issues
* Fixed formatting issue.
* completed Juuxl's suggestions and removed null check on adding skyproperties. Changed SkyProperties registering to take an Identifier. Registration turns out to be only adding new options to the "effects" entry of dimension type jsonjson.
* Forgot to reenable this.
* Just did suggested tweaks
* Changed SkyProperties to DimensionEffects
* Pushed suggestions of Haykam and apple502j
* Added missing changes from sky properties to dimension effects.
* Corrected me being inconsistent.
* Forgot to remove import.
* Impliments
https://github.com/FabricMC/fabric/pull/1727#discussion_r734988305https://github.com/FabricMC/fabric/pull/1727#discussion_r734988265
* Implements https://github.com/FabricMC/fabric/pull/1727#discussion_r730429748
* Last minute tweak. Runnable that controls fog runs right before dimension spefific rendering is done. Based on more subtle issues discovered while working api with twilight forest.
Co-authored-by: AlphaMode <AlphaModeYT@gmail.com>
* Deprecate and move fabric-rendering-registries-v1 into fabric-rendering-v1
* Make the event work again
* Use lambda for RegistrationHelper
* Checkstyle in rendererregistries
* Checkstyle for rendering-v1
* Remove mixins file
And add two `forRemoval`
* Raise EntityModelLayerRegistry out of experimental
And update javadoc
* Change INSTANCE to a static method in two registries
* Readd unwillingly removed annotation
* Disallow constructing API instances
* Added Environment and ApiStatus annotations
* Update testmod's entrypoint
Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com>
* Remove renderer-registries testmod
* Remove `var` usage
* Don't specify `forRemoval = true` in `@Deprecated`
* Inline old registry implementations in anonymous classes
Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com>
* reimplement ArmorRenderingRegistry
* fix license headers
* remove todo
* move registry to static method
* minor reformat
* reduce api classes into one
* reformat
* make registry static
* reformat
* change Item in registry to ItemConvertible
* register mixin properly this time
* explain test mod
* reformat
* stricter null check
* Add custom value denoting module lifecycles.
* Make the module validation work.
My hand has been forced - we must use buildSrc since JsonSlurper is not available in main buildscript.
* Apply task to each project and dont cross projects
* A horrible hack
* Wait what
* It works now.
* Not needed
* Drop unneeded maven repo, cache map lookup
(cherry picked from commit daa38b3d82)
* Add WorldRenderEvents
* Fix typos
* Incorporate PR feedback
* Simplify context and block outline events
* Update implementation
* Ensure the BLOCK_OUTLINE mixin does nothing if BEFORE_BLOCK_OUTLINE mixin is disabled
* Document event order in class header
* Update fabric-rendering-v1/src/main/java/net/fabricmc/fabric/api/client/rendering/v1/WorldRenderEvents.java
Co-authored-by: Juuxel <6596629+Juuxel@users.noreply.github.com>
* Add environment tag to nested type
* More envionment tags
Co-authored-by: Juuxel <6596629+Juuxel@users.noreply.github.com>
(cherry picked from commit c26373137e)
* Boost to Loom 0.5
Add null related annotations
* Rearrange nullable to be overline
* Fix anno sorting for picky
* Add imports
* Address feedback
* Fix import
* Add item renderer with model transformation mode, deprecate old one.
This PR simply adds a new interface which supplies the additional `Mode` parameter.
All old renderers are delegated to an implementation of the new renderer, thereby making this PR still backwards compatable with all existing renderers.
(cherry picked from commit 7c9162e99f48c6e3989eec9a46afaa935d65ce30)
* Update fabric-rendering-v1/src/main/java/net/fabricmc/fabric/api/client/rendering/v1/BuiltinItemRendererWithMode.java
Co-authored-by: shartte <shartte@users.noreply.github.com>
* Rename new interfact to `DynamicItemRenderer`, make it an inner class of the registry class.
* Update fabric-rendering-v1/src/main/java/net/fabricmc/fabric/impl/client/rendering/BuiltinItemRendererRegistryImpl.java
Co-authored-by: liach <7806504+liach@users.noreply.github.com>
* Update BuiltinItemRendererRegistryImpl.java
* Update BuiltinItemRendererRegistryImpl.java
* Imports
* Use ItemConvertible for new render method
* Rename new interfact to `DynamicItemRenderer`, make it an inner class of the registry class.
fabric-rendering-v1/src/main/java/net/fabricmc/fabric/api/client/rendering/v1/BuiltinItemRendererRegistry.java
* Move inner class out, fix formatting issue in loot-tables with linux oses
* why was this multilined
* license header lol
* Apply suggestions from code review
Co-authored-by: liach <7806504+liach@users.noreply.github.com>
* Make renderer a nested class again
* putIfAbsent
Co-authored-by: shartte <shartte@users.noreply.github.com>
Co-authored-by: liach <7806504+liach@users.noreply.github.com>
