FabricMC/fabric
1
0
Fork 1
mirror of https://github.com/FabricMC/fabric.git synced 2025-02-17 04:01:46 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix empty data attachments being saved. (#3588)

Browse source 
* Fix empty data attachments being saved.

* Checkstyle
This commit is contained in:
modmuss 2024-02-12 18:01:13 +00:00
parent 41e516f9db
commit de0fd6d132
2 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
fabric-data-attachment-api-v1/src/main/java/net/fabricmc/fabric/impl/attachment/AttachmentSerializingImpl.java
View file

@ -37,7 +37,7 @@ public class AttachmentSerializingImpl {
@SuppressWarnings("unchecked")
public static void serializeAttachmentData(NbtCompound nbt, @Nullable IdentityHashMap<AttachmentType<?>, ?> attachments) {
if (attachments == null) {
if (attachments == null || attachments.isEmpty()) {
return;
}
@ -61,10 +61,10 @@ public class AttachmentSerializingImpl {
nbt.put(AttachmentTarget.NBT_ATTACHMENT_KEY, compound);
}
@Nullable
public static IdentityHashMap<AttachmentType<?>, Object> deserializeAttachmentData(NbtCompound nbt) {
var attachments = new IdentityHashMap<AttachmentType<?>, Object>();
if (nbt.contains(AttachmentTarget.NBT_ATTACHMENT_KEY, NbtElement.COMPOUND_TYPE)) {
var attachments = new IdentityHashMap<AttachmentType<?>, Object>();
NbtCompound compound = nbt.getCompound(AttachmentTarget.NBT_ATTACHMENT_KEY);
for (String key : compound.getKeys()) {
@ -89,9 +89,15 @@ public class AttachmentSerializingImpl {
);
}
}
if (attachments.isEmpty()) {
return null;
}
return attachments;
}
return attachments;
return null;
}
public static boolean hasPersistentAttachments(@Nullable IdentityHashMap<AttachmentType<?>, ?> map) {

19
fabric-data-attachment-api-v1/src/test/java/net/fabricmc/fabric/test/attachment/CommonAttachmentTests.java
View file

@ -147,6 +147,25 @@ public class CommonAttachmentTests {
assertEquals(0.5d, entry.getValue());
}
@Test
void deserializeNull() {
var nbt = new NbtCompound();
assertNull(AttachmentSerializingImpl.deserializeAttachmentData(nbt));
nbt.put(new Identifier("test").toString(), new NbtCompound());
assertNull(AttachmentSerializingImpl.deserializeAttachmentData(nbt));
}
@Test
void serializeNullOrEmpty() {
var nbt = new NbtCompound();
AttachmentSerializingImpl.serializeAttachmentData(nbt, null);
assertFalse(nbt.contains(AttachmentTarget.NBT_ATTACHMENT_KEY));
AttachmentSerializingImpl.serializeAttachmentData(nbt, new IdentityHashMap<>());
assertFalse(nbt.contains(AttachmentTarget.NBT_ATTACHMENT_KEY));
}
@Test
void testEntityCopy() {
AttachmentType<Boolean> notCopiedOnRespawn = AttachmentRegistry.create(