Fix day/night-cycle enabling in World.isDay and World.isNight being

hardcoded for Overworld, use Dimension.hasVisibleSky instead.

- World.isDay() and World.isNight() are now un-hardcoded.
  Instead of checking for the overworld, they check for a visible sky
  like clocks. The check is false for the nether and the end,
  so vanilla behaviour stays the same.

fabric-dimensions-v1/build.gradle

@@ -1,5 +1,5 @@
 archivesBaseName = "fabric-dimensions-v1"
-version = getSubprojectVersion(project, "0.2.5")
+version = getSubprojectVersion(project, "0.3.0")
 
 dependencies {
 	compile project(path: ':fabric-api-base', configuration: 'dev')

fabric-dimensions-v1/src/main/java/net/fabricmc/fabric/mixin/dimension/MixinWorld.java

@@ -0,0 +1,42 @@
+/*
+ * Copyright (c) 2016, 2017, 2018, 2019 FabricMC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package net.fabricmc.fabric.mixin.dimension;
+
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Redirect;
+
+import net.minecraft.world.World;
+import net.minecraft.world.dimension.Dimension;
+import net.minecraft.world.dimension.DimensionType;
+
+@Mixin(World.class)
+public abstract class MixinWorld {
+	/* World.isDay() and World.isNight() enable the day-night cycle as well as some entity behavior
+	 * (such as bees). In vanilla, these methods are hardcoded to only work in the overworld. This
+	 * redirector pretends that all dimensions with a visible sky are DimensionType.OVERWORLD, which
+	 * makes the time checks for modded dimensions work.
+	 *
+	 * Dimension.hasVisibleSky() is true for the overworld, false for the nether and the end, and
+	 * customizable for modded dimensions. It is already used for time checking in other places
+	 * such as clocks.
+	 */
+	@Redirect(method = {"isDay", "isNight"}, at = @At(value = "INVOKE", target = "Lnet/minecraft/world/dimension/Dimension;getType()Lnet/minecraft/world/dimension/DimensionType;"))
+	private DimensionType replaceCustomDimensionsWithOverworld(Dimension dimension) {
+		return dimension.hasVisibleSky() ? DimensionType.OVERWORLD : dimension.getType();
+	}
+}

fabric-dimensions-v1/src/main/resources/fabric-dimensions-v1.mixins.json

@@ -6,6 +6,7 @@
     "EntityHooks",
     "MixinEntity",
     "MixinPortalForcer",
+    "MixinWorld",
     "idremap.MixinDimensionRawIndexFix",
     "idremap.MixinLevelProperties",
     "idremap.MixinLevelStorage",