FabricMC/fabric
1
0
Fork 1
mirror of https://github.com/FabricMC/fabric.git synced 2024-11-14 19:25:23 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove now unneeded OverlayVertexConsumerMixin (#3613)

Browse source
This commit is contained in:
Technici4n 2024-02-25 14:30:26 +01:00 committed by GitHub
parent 4fcbeea9b2
commit a167fc4d2d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 62 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
fabric-renderer-api-v1/src/client/java/net/fabricmc/fabric/mixin/renderer/client/OverlayVertexConsumerMixin.java
View file

@ -1,60 +0,0 @@
/*
* Copyright (c) 2016, 2017, 2018, 2019 FabricMC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package net.fabricmc.fabric.mixin.renderer.client;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Unique;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Redirect;
import net.minecraft.client.render.OverlayVertexConsumer;
import net.minecraft.util.math.Direction;
import net.minecraft.util.math.MathConstants;
@Mixin(OverlayVertexConsumer.class)
public class OverlayVertexConsumerMixin {
@Unique
private static final Direction[] DIRECTIONS = Direction.values();
/*
The original method call is used to get the closest axis-aligned direction of the world-space
normal vector for a certain face. The world-space normal vector is computed using matrices
that change when the camera values change. Due to precision errors during matrix
multiplication, the computed world-space normal of a face will not remain constant, so the
closest axis-aligned direction may flicker. This issue only affects faces that are directly
between two axis-aligned directions (45 degree faces) or three axis-aligned directions.
The fix involves requiring the dot product of each axis-aligned direction to be a small
amount greater than the previous maximum dot product to be set as the new maximum.
*/
@Redirect(method = "next()V", at = @At(value = "INVOKE", target = "Lnet/minecraft/util/math/Direction;getFacing(FFF)Lnet/minecraft/util/math/Direction;"))
private Direction redirectGetFacing(float x, float y, float z) {
Direction closestDir = Direction.NORTH;
float maxDot = 1.4E-45F;
for (Direction direction : DIRECTIONS) {
float dot = x * direction.getOffsetX() + y * direction.getOffsetY() + z * direction.getOffsetZ();
if (dot > maxDot + MathConstants.EPSILON) {
maxDot = dot;
closestDir = direction;
}
}
return closestDir;
}
}

3
fabric-renderer-api-v1/src/client/resources/fabric-renderer-api-v1.mixins.json
View file

@ -6,8 +6,7 @@
"client.BakedModelMixin",
"client.MultipartBakedModelMixin",
"client.WeightedBakedModelMixin",
"client.SpriteAtlasTextureMixin",
"client.OverlayVertexConsumerMixin"
"client.SpriteAtlasTextureMixin"
],
"injectors": {
"defaultRequire": 1