FabricMC/fabric
1
0
Fork 1
mirror of https://github.com/FabricMC/fabric.git synced 2024-11-14 19:25:23 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fabric-networking: correctly catch and warn on invalid identifiers, instead of crashing

Browse source
This commit is contained in:
asie 2019-04-27 16:07:57 +02:00
parent 40a5359da7
commit 409e03e8dd
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
fabric-networking/src/main/java/net/fabricmc/fabric/impl/network/PacketRegistryImpl.java
View file

@ -22,6 +22,7 @@ import net.fabricmc.fabric.api.network.PacketContext;
import net.fabricmc.fabric.api.network.PacketRegistry;
import net.minecraft.network.Packet;
import net.minecraft.util.Identifier;
import net.minecraft.util.InvalidIdentifierException;
import net.minecraft.util.PacketByteBuf;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@ -103,7 +104,12 @@ public abstract class PacketRegistryImpl implements PacketRegistry {
if (c == 0) {
String s = sb.toString();
if (!s.isEmpty()) {
ids.add(new Identifier(s));
try {
ids.add(new Identifier(s));
} catch (InvalidIdentifierException e) {
LOGGER.warn("Received invalid identifier in " + id + ": " + s + " (" + e.getLocalizedMessage() + ")");
LOGGER.trace(e);
}
}
sb = new StringBuilder();
} else {